Commit 3436c2d
authored
Merge pull request #1183 from luissimas/restrict-websockets-version
#1183
#### Description
Restricts the websockets library version to only install releases before 14.0. This is needed since websockets 14 introduces a number of breaking changes that are not compatible with python-libjuju.
Resolves
- #1184
#### QA Steps
```
tox -e integration
```
#### Notes & Discussion
@luissimas said:
I've noticed this problem when my integration tests started failing today without any apparent reason. The version 14.0 of websockets was released yesterday. You can check the changelog at: https://websockets.readthedocs.io/en/stable/project/changelog.html. It's worth noting that this new version of websockets drops support for Python 3.8.
For the sake of completeness, I was getting this error on my integration tests:
```
Traceback (most recent call last):
File "/home/runner/actions-runner/_work/my-charm/my-charm/.tox/integration/lib/python3.10/site-packages/juju/client/connection.py", line 873, in _connect_with_login
result = (await self.login())['response']
File "/home/runner/actions-runner/_work/my-charm/my-charm/.tox/integration/lib/python3.10/site-packages/juju/client/connection.py", line 970, in login
return await self.rpc({
File "/home/runner/actions-runner/_work/my-charm/my-charm/.tox/integration/lib/python3.10/site-packages/juju/client/connection.py", line 643, in rpc
if self.monitor.status == Monitor.DISCONNECTED:
File "/home/runner/actions-runner/_work/my-charm/my-charm/.tox/integration/lib/python3.10/site-packages/juju/client/connection.py", line 224, in status
if stopped or not connection._ws.open:
AttributeError: 'ClientConnection' object has no attribute 'open'
```2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
0 commit comments