Skip to content

Commit 2990139

Browse files
committed
Ask for credentials if some missing before connect
Fixes #1001
1 parent 5e19882 commit 2990139

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

juju/client/connector.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,9 @@ async def connect(self, **kwargs):
8989
if 'password' not in kwargs and account.get('password'):
9090
kwargs.update(password=account.get('password'))
9191

92+
if not ({'username', 'password'}.issubset(kwargs)):
93+
required = {'username', 'password'}.difference(kwargs)
94+
raise ValueError(f'Some authentication parameters are required : {",".join(required)}')
9295
self._connection = await Connection.connect(**kwargs)
9396

9497
if not self.controller_name:

0 commit comments

Comments
 (0)