Skip to content

Commit 263c2d6

Browse files
committed
chore: hint machine addresses as list of dicts
Having `list[str]` has type-hinting made working with a type-checker awkward as an addresses is defined as a dict of mostly [str, str] key-values pairs, with one key-value being a [str, boolean] key-value pairs. Signed-off-by: Guillaume Boutry <guillaume.boutry@canonical.com>
1 parent fdbbbe9 commit 263c2d6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

juju/machine.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ async def ssh(
227227
return stdout.decode()
228228

229229
@property
230-
def addresses(self) -> typing.List[str]:
230+
def addresses(self) -> typing.List[dict]:
231231
"""Returns the machine addresses."""
232232
return self.safe_data["addresses"] or []
233233

0 commit comments

Comments
 (0)