Skip to content

Commit 166a66c

Browse files
committed
Cleanup based on review comments
1 parent 97e3cd1 commit 166a66c

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

juju/client/connection.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,6 @@ def _exit_tasks():
433433
max_size=self.max_frame_size,
434434
server_hostname=server_hostname,
435435
sock=sock,
436-
close_timeout=1,
437436
)), url, endpoint, cacert
438437

439438
async def close(self, to_reconnect=False):
@@ -645,7 +644,7 @@ async def rpc(self, msg, encoder=None):
645644
if "version" not in msg:
646645
msg['version'] = self.facades[msg['type']]
647646
outgoing = json.dumps(msg, indent=2, cls=encoder)
648-
log.debug('connection id: {} -- sending {}'.format(id(self), outgoing))
647+
log.debug('connection id: {} ---> {}'.format(id(self), outgoing))
649648
for attempt in range(3):
650649
if self.monitor.status == Monitor.DISCONNECTED:
651650
# closed cleanly; shouldn't try to reconnect
@@ -668,7 +667,7 @@ async def rpc(self, msg, encoder=None):
668667
log.error('RPC: Automatic reconnect failed')
669668
raise
670669
result = await self._recv(msg['request-id'])
671-
log.debug('connection id : {} -- receiving {}'.format(id(self), result))
670+
log.debug('connection id : {} <--- {}'.format(id(self), result))
672671

673672
if not result:
674673
return result

juju/model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -771,7 +771,7 @@ async def watch_received_waiter():
771771
raise JujuError("AllWatcher task is finished abruptly without an exception.")
772772
raise self._watcher_task.exception()
773773

774-
if self.info is None:
774+
if self._info is None:
775775
# TODO (cderici): See if this can be optimized away, or at least
776776
# be done lazily (i.e. not everytime after_connect, but whenever
777777
# self.info is needed -- which here can be bypassed if model_uuid
@@ -799,7 +799,7 @@ async def disconnect(self):
799799
self._watch_stopping.clear()
800800

801801
if self.is_connected():
802-
await self._connector.disconnect(entity='Model')
802+
await self._connector.disconnect(entity='model')
803803
self._info = None
804804

805805
async def add_local_charm_dir(self, charm_dir, series):

0 commit comments

Comments
 (0)