Perform left outer join instead of inner join when filtering by relations to fix "OR" queries on relation properties

techniq · techniq · commit 3a717355d892 · 2016-03-23T07:52:15.000-04:00
diff --git a/src/index.js b/src/index.js
@@ -43,7 +43,7 @@ function processRelationField (resourceConfig, query, field, criteria, options,
           let relationTable = getTable(relationResourceConfig)
           let foreignId = `${relationTable}.${relationResourceConfig.idAttribute}`
 
-          query.join(relationTable, localId, foreignId)
+          query.leftJoin(relationTable, localId, foreignId)
           joinedTables.push(relationPath.join('.'))
         }
       } else if (relation.type === 'hasMany') {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ function processRelationField (resourceConfig, query, field, criteria, options,`
`43`	`43`	`let relationTable = getTable(relationResourceConfig)`
`44`	`44`	let foreignId = `${relationTable}.${relationResourceConfig.idAttribute}`
`45`	`45`
`46`		`- query.join(relationTable, localId, foreignId)`
	`46`	`+ query.leftJoin(relationTable, localId, foreignId)`
`47`	`47`	`joinedTables.push(relationPath.join('.'))`
`48`	`48`	`}`
`49`	`49`	`} else if (relation.type === 'hasMany') {`