Merge pull request #190 from chieffancypants/unlinkInverse-bug

jmdobry · jmdobry · commit 3b5f589cf0c8 · 2014-09-26T15:06:51.000-06:00
unlinkInverse: avoid splicing when index is undefined
diff --git a/src/datastore/sync_methods/unlinkInverse.js b/src/datastore/sync_methods/unlinkInverse.js
@@ -17,7 +17,9 @@ function _unlinkInverse(definition, linked) {
                     index = i;
                   }
                 });
-                item[def.localField].splice(index, 1);
+                if (index !== undefined) {
+                  item[def.localField].splice(index, 1);
+                }
               } else if (item[def.localField] === linked) {
                 delete item[def.localField];
               }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,9 @@ function _unlinkInverse(definition, linked) {`
`17`	`17`	`index = i;`
`18`	`18`	`}`
`19`	`19`	`});`
`20`		`- item[def.localField].splice(index, 1);`
	`20`	`+ if (index !== undefined) {`
	`21`	`+ item[def.localField].splice(index, 1);`
	`22`	`+ }`
`21`	`23`	`} else if (item[def.localField] === linked) {`
`22`	`24`	`delete item[def.localField];`
`23`	`25`	`}`