Skip to content

Commit 15b082f

Browse files
committed
chore: Simplify bundler CI workarounds
Avoid need for CI to be aware; just use the default bundler with whatever JRuby version we are running with
1 parent d6c1d10 commit 15b082f

5 files changed

Lines changed: 6 additions & 23 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,11 @@ jobs:
2121
matrix:
2222
java-version: [8, 21]
2323
ruby-version: [jruby-9.4, jruby-10]
24-
bundler-version: [2.6.3, 2.7.1]
2524
task: ['', integration]
2625
exclude:
2726
# JRuby 10 requires Java 21 minimum
2827
- ruby-version: jruby-10
2928
java-version: 8
30-
# Bundler 2.7.1 requires Ruby 3.2
31-
- ruby-version: jruby-9.4
32-
bundler-version: 2.7.1
3329

3430
fail-fast: false
3531

@@ -44,7 +40,7 @@ jobs:
4440
- name: Set up java ${{ matrix.java-version }}
4541
uses: actions/setup-java@v3
4642
with:
47-
distribution: zulu
43+
distribution: temurin
4844
java-version: ${{ matrix.java-version }}
4945

5046
- name: Set up ${{ matrix.ruby-version }}
@@ -55,11 +51,8 @@ jobs:
5551
- name: Remove jruby-launcher # not sure where this is coming from but causes some specs to fail
5652
run: gem uninstall -a jruby-launcher
5753

58-
- name: Remove jruby-launcher # not sure where this is coming from but causes some specs to fail
59-
run: gem install bundler -v ${{ matrix.bundler-version }}
60-
6154
- name: Install dependencies
62-
run: bundle _${{ matrix.bundler-version }}_ install --jobs=3 --retry=3
55+
run: bundle install
6356

6457
- name: Run tests
65-
run: bundle _${{ matrix.bundler-version }}_ exec rake ${{ matrix.task }}
58+
run: bundle exec rake ${{ matrix.task }}

Mavenfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ properties(
2020
'project.build.sourceEncoding' => 'UTF-8',
2121
'jruby.plugins.version' => '3.0.6',
2222
'jetty.version' => '9.4.58.v20250814',
23-
'bundler.version' => '2.6.3',
2423
)
2524

2625
# dependencies needed for compilation

Rakefile

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,8 @@
66
# See the file LICENSE.txt for details.
77
#++
88

9-
begin
10-
require 'bundler'
11-
rescue LoadError
12-
warn "\nPlease `gem install bundler' and run `bundle install' to ensure you have all dependencies.\n\n"
13-
else
14-
require 'bundler/gem_helper'
15-
Bundler::GemHelper.install_tasks :dir => File.dirname(__FILE__)
16-
end
9+
require 'bundler/gem_helper'
10+
Bundler::GemHelper.install_tasks :dir => File.dirname(__FILE__)
1711

1812
require 'rake/clean'
1913
CLEAN << "pkg" << "doc" << Dir['integration/**/target']

spec/sample_bundler/Gemfile.lock

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,3 @@ PLATFORMS
1010

1111
DEPENDENCIES
1212
rake (= 13.3.0)
13-
14-
BUNDLED WITH
15-
2.6.3

spec/warbler/bundler_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def use_config(&block)
2323
end
2424

2525
def bundle_install(*args)
26-
`cd #{Dir.pwd} && #{RUBY_EXE} -S bundle _#{::Bundler::VERSION}_ install #{args.join(' ')}`
26+
`cd #{Dir.pwd} && #{RUBY_EXE} -S bundle install #{args.join(' ')}`
2727
end
2828

2929
let(:config) { drbclient.config(@extra_config) }

0 commit comments

Comments
 (0)