[feat] remove SHA1PRNG fallback: use default SecureRandom

ehen the preferred PRNG (NativePRNGNonBlocking) is unavailable, fall
through directly to new SecureRandom() which lets the JDK pick the best
available provider

Author: kares

src/main/java/org/jruby/ext/openssl/Random.java

@@ -160,7 +160,7 @@ private static void setSecureRandom(ThreadContext context, java.security.SecureR
             }
             // setting it to "" (empty) or "default" should just use new SecureRandom() :
             if (prng.isEmpty() || prng.equalsIgnoreCase("default")) {
-                prng = null; tryPreferredPRNG = false; trySHA1PRNG = false;
+                prng = null; tryPreferredPRNG = false;
             }
 
             PREFERRED_PRNG = prng;
@@ -177,7 +177,6 @@ private static void setSecureRandom(ThreadContext context, java.security.SecureR
         }
 
         private static boolean tryPreferredPRNG = true;
-        private static boolean trySHA1PRNG = true;
         private static boolean tryStrongPRNG = false; // NOT-YET-IMPLEMENTED
 
         // copied from JRuby (not available in all 1.7.x) :
@@ -194,17 +193,6 @@ public java.security.SecureRandom getSecureRandomImpl() {
                 }
             }
 
-            // Try SHA1PRNG
-            if (secureRandom == null && trySHA1PRNG) {
-                try {
-                    secureRandom = java.security.SecureRandom.getInstance("SHA1PRNG");
-                }
-                catch (Exception e) {
-                    trySHA1PRNG = false;
-                    OpenSSL.debug("SecureRandom SHA1PRNG failed:", e);
-                }
-            }
-
             // Just let JDK do whatever it does
             if (secureRandom == null) {
                 secureRandom = new java.security.SecureRandom();

src/main/java/org/jruby/ext/openssl/x509store/PEMInputOutput.java

@@ -1213,12 +1213,7 @@ private static void writePemEncrypted(final BufferedWriter out,
 
     private static SecureRandom secureRandom() {
         if ( random == null ) {
-            try {
-                random = SecureRandom.getInstance("SHA1PRNG");
-            }
-            catch (NoSuchAlgorithmException e) {
-                random = new SecureRandom();
-            }
+            random = new SecureRandom();
         }
         return random;
     }