Skip to content
This repository was archived by the owner on Aug 19, 2022. It is now read-only.

Commit 580dd9c

Browse files
committed
Updated to 1.1.6 version
1 parent c02f7ac commit 580dd9c

6 files changed

Lines changed: 178 additions & 137 deletions

File tree

CHANGELOG.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,31 @@
5757
* Added `Josantonius\Database\Test\InsertTest->testInsertMethodTableNameError()` method.
5858
* Added `Josantonius\Database\Test\InsertTest->testInsertMethodColumnNameError()` method.
5959

60+
* Added `Josantonius\Database\Test\SelectTest` class.
61+
* Added `Josantonius\Database\Test\SelectTest->testGetConnection()` method.
62+
* Added `Josantonius\Database\Test\SelectTest->testSelectQuery_Multiple_Object()` method.
63+
* Added `Josantonius\Database\Test\SelectTest->testSelectQuery_SelectAll_Limit_Numeric()` method.
64+
* Added `Josantonius\Database\Test\SelectTest->testSelectQuery_Multiple_Where_Order_Assoc()` method.
65+
* Added `Josantonius\Database\Test\SelectTest->testSelectQuery_Multiple_Rows()` method.
66+
* Added `Josantonius\Database\Test\SelectTest->testSelectQuery_Multiple_Statements_Where_Object()` method.
67+
* Added `Josantonius\Database\Test\SelectTest->testSelectQueryTableNamError()` method.
68+
* Added `Josantonius\Database\Test\SelectTest->testSelectQueryColumnNamError()` method.
69+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_SelectAll_Object()` method.
70+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_SelectAll_Numeric()` method.
71+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_SelectAll_Assoc()` method.
72+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_Limit_Object()` method.
73+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_Multiple_Where_Assoc()` method.
74+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_Multiple_Where_Order_Limit_Object()` method.
75+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_Order_Where_Multiple_Limit_Object()` method.
76+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_Statements_Where_Multiple_Object()` method.
77+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_Statements_Where_Advanced_Assoc()` method.
78+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethodWhenThereAreNoResults()` method.
79+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_Where_Rows()` method.
80+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_MarksStatements_Where_Advanced()` method.
81+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethod_Marks_DataType_Where_Advanced()` method.
82+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethodTableNameError()` method.
83+
* Added `Josantonius\Database\Test\SelectTest->testSelectMethodColumnNameError()` method.
84+
6085
## 1.1.5 - 2017-07-03
6186

6287
* Bug fix in replace method.

phpunit.xml.dist

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
<server name='DOCUMENT_ROOT' value='/var/www/josantonius/public' />
2020
<server name='SERVER_PORT' value='80' />
2121
<server name='HTTP_REFERER' value='https://www.google.es/' />
22-
22+
23+
<var name="ID" value="" />
2324
<var name="DB_HOST" value="127.0.0.1" />
2425
<var name="DB_USER" value="travis" />
2526
<var name="DB_PASSWORD" value="" />
@@ -32,6 +33,7 @@
3233
<file>tests/Database/Test/CreateTest.php</file>
3334
<file>tests/Database/Test/InsertTest.php</file>
3435
<file>tests/Database/Test/SelectTest.php</file>
36+
<file>tests/Database/Test/ReplaceTest.php</file>
3537
</testsuite>
3638
</testsuites>
3739

src/Database/Provider/PDOprovider/PDOprovider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ public function replace($table, $data, $statements) {
380380

381381
$columnIdName = $columns[0];
382382

383-
if ($statements && isset($statements[0][1])) {
383+
if (count($data) == count($statements) && isset($statements[0][1])) {
384384

385385
$id = $statements[0][1];
386386

tests/Database/Test/InsertTest.php

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ public function testInsertQuery_ID($db) {
7474
VALUES ("Isis", "isis@email.com")',
7575
false,
7676
'id'
77-
);
77+
);
78+
79+
$GLOBALS['ID'] = $result;
7880

7981
$this->assertInternalType('int', $result);
8082
}
@@ -114,7 +116,11 @@ public function testInsertQuery_Statements_Rows($db) {
114116
*/
115117
public function testInsertQuery_Statements_DataType_Rows($db) {
116118

117-
$statements[] = [":id", 100, "int"];
119+
$id = rand(1, 999999);
120+
121+
$GLOBALS['ID'] = $id;
122+
123+
$statements[] = [":id", $id, "int"];
118124
$statements[] = [":name", "Isis", "str"];
119125
$statements[] = [":email", "isis@email.com", "str"];
120126

@@ -143,7 +149,9 @@ public function testInsertQuery_Statements_DataType_Rows($db) {
143149
*/
144150
public function testInsertQuery_Duplicate_Statements_DataType_Rows($db) {
145151

146-
$statements[] = [":id", 100, "int"];
152+
$id = $GLOBALS['ID'];
153+
154+
$statements[] = [":id", $id, "int"];
147155
$statements[] = [":name", "Isis", "str"];
148156
$statements[] = [":email", "isis@email.com", "str"];
149157

@@ -177,6 +185,8 @@ public function testInsertQuery_Statements_ID($db) {
177185
'id'
178186
);
179187

188+
$GLOBALS['ID'] = $result;
189+
180190
$this->assertInternalType('int', $result);
181191
}
182192

@@ -191,7 +201,11 @@ public function testInsertQuery_Statements_ID($db) {
191201
*/
192202
public function testInsertQuery_Statements_DataType_ID($db) {
193203

194-
$statements[] = [1, 200, "int"];
204+
$id = rand(1, 999999);
205+
206+
$GLOBALS['ID'] = $id;
207+
208+
$statements[] = [1, $id, "int"];
195209
$statements[] = [2, "Isis", "str"];
196210
$statements[] = [3, "isis@email.com", "str"];
197211

@@ -203,7 +217,7 @@ public function testInsertQuery_Statements_DataType_ID($db) {
203217
'id'
204218
);
205219

206-
$this->assertEquals(200, $result);
220+
$this->assertEquals($id, $result);
207221
}
208222

209223
/**

0 commit comments

Comments
 (0)