Skip to content

Commit e214998

Browse files
committed
fix hikari test after upgrade
1 parent d62fcef commit e214998

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

jooby-jdbc/src/test/java/org/jooby/jdbc/JdbcTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ public void hikariDefaultsDev() throws Exception {
516516
assertEquals(0, hikariConfig.getLeakDetectionThreshold());
517517
assertEquals(1800000, hikariConfig.getMaxLifetime());
518518
assertEquals(10, hikariConfig.getMaximumPoolSize());
519-
assertEquals(-1, hikariConfig.getMinimumIdle());
519+
assertEquals(10, hikariConfig.getMinimumIdle());
520520
assertEquals("h2.db", hikariConfig.getPoolName());
521521
assertEquals(null, hikariConfig.getTransactionIsolation());
522522
});
@@ -533,7 +533,7 @@ public void hikariOverrideDefaults() throws Exception {
533533

534534
long connectionTimeout = 1000;
535535
int maximumPoolSize = 10;
536-
long idleTimeout = 2000;
536+
long idleTimeout = 800000;
537537
// config
538538
config = config.withValue("db", fromAnyRef("mem"))
539539
// hikari override
@@ -575,7 +575,7 @@ public void hikariOverrideDefaults() throws Exception {
575575
assertEquals(0, hikariConfig.getLeakDetectionThreshold());
576576
assertEquals(1800000, hikariConfig.getMaxLifetime());
577577
assertEquals(maximumPoolSize, hikariConfig.getMaximumPoolSize());
578-
assertEquals(-1, hikariConfig.getMinimumIdle());
578+
assertEquals(10, hikariConfig.getMinimumIdle());
579579
assertEquals("h2.db", hikariConfig.getPoolName());
580580
assertEquals(null, hikariConfig.getTransactionIsolation());
581581
});
@@ -979,6 +979,7 @@ private static void withHikariConfig(final Provider<DataSource> provider,
979979
HikariDataSourceProvider hikariProvider = (HikariDataSourceProvider) provider;
980980

981981
HikariConfig hikariConfig = hikariProvider.config();
982+
hikariConfig.validate();
982983
assertNotNull(hikariConfig);
983984

984985
asserts.accept(hikariConfig, hikariConfig.getDataSourceProperties());

0 commit comments

Comments
 (0)