replace Jooby.redirect for Results.redirect (code cleanup)

Author: jknack

coverage-report/src/test/java/org/jooby/RedirectFeature.java

@@ -44,23 +44,23 @@ public String here() {
 
   {
 
-    get("/l1/l2/l3", redirect("/l1"));
+    get("/l1/l2/l3", () -> Results.redirect("/l1"));
 
     get("/l1", (req, rsp) -> rsp.send(req.path()));
 
-    get("/blog/admin", redirect("post/new"));
+    get("/blog/admin", () -> Results.redirect("post/new"));
 
     get("/blog/admin/post/new", (req, rsp) -> rsp.send(req.path()));
 
     get("/blog/post/new", (req, rsp) -> rsp.send(req.path()));
 
-    get("/d1/d2/d3", redirect(".."));
+    get("/d1/d2/d3", () -> Results.redirect(".."));
 
-    get("/d1/d2/d3b", redirect("../d2"));
+    get("/d1/d2/d3b", () -> Results.redirect("../d2"));
 
-    get("/d1/d2/d3c", redirect("./d2"));
+    get("/d1/d2/d3c", () -> Results.redirect("./d2"));
 
-    get("/back", redirect("back"));
+    get("/back", () -> Results.redirect("back"));
 
     get("/d1", (req, rsp) -> rsp.send(req.path()));
 

jooby/src/main/java/org/jooby/Jooby.java

@@ -2487,132 +2487,6 @@ public Route.Definition head(final @Nonnull String path, final @Nonnull Route.Ha
     return this;
   }
 
-  /**
-   * Redirect to the given url with status code defaulting to {@link Status#FOUND}.
-   *
-   * <pre>
-   *  rsp.redirect("/foo/bar");
-   *  rsp.redirect("http://example.com");
-   *  rsp.redirect("http://example.com");
-   *  rsp.redirect("../login");
-   * </pre>
-   *
-   * Redirects can be a fully qualified URI for redirecting to a different site:
-   *
-   * <pre>
-   *   rsp.redirect("http://google.com");
-   * </pre>
-   *
-   * Redirects can be relative to the root of the host name. For example, if you were
-   * on <code>http://example.com/admin/post/new</code>, the following redirect to /admin would
-   * land you at <code>http://example.com/admin</code>:
-   *
-   * <pre>
-   *   rsp.redirect("/admin");
-   * </pre>
-   *
-   * Redirects can be relative to the current URL. A redirection of post/new, from
-   * <code>http://example.com/blog/admin/</code> (notice the trailing slash), would give you
-   * <code>http://example.com/blog/admin/post/new.</code>
-   *
-   * <pre>
-   *   rsp.redirect("post/new");
-   * </pre>
-   *
-   * Redirecting to post/new from <code>http://example.com/blog/admin</code> (no trailing slash),
-   * will take you to <code>http://example.com/blog/post/new</code>.
-   *
-   * <p>
-   * If you found the above behavior confusing, think of path segments as directories (have trailing
-   * slashes) and files, it will start to make sense.
-   * </p>
-   *
-   * Pathname relative redirects are also possible. If you were on
-   * <code>http://example.com/admin/post/new</code>, the following redirect would land you at
-   * <code>http//example.com/admin</code>:
-   *
-   * <pre>
-   *   rsp.redirect("..");
-   * </pre>
-   *
-   * A back redirection will redirect the request back to the <code>Referer</code>, defaulting to
-   * <code>/</code> when missing.
-   *
-   * <pre>
-   *   rsp.redirect("back");
-   * </pre>
-   *
-   * @param location Either a relative or absolute location.
-   * @return A route handler.
-   */
-  public Route.Handler redirect(final String location) {
-    return redirect(Status.FOUND, location);
-  }
-
-  /**
-   * Redirect to the given url with status code defaulting to {@link Status#FOUND}.
-   *
-   * <pre>
-   *  rsp.redirect("/foo/bar");
-   *  rsp.redirect("http://example.com");
-   *  rsp.redirect("http://example.com");
-   *  rsp.redirect("../login");
-   * </pre>
-   *
-   * Redirects can be a fully qualified URI for redirecting to a different site:
-   *
-   * <pre>
-   *   rsp.redirect("http://google.com");
-   * </pre>
-   *
-   * Redirects can be relative to the root of the host name. For example, if you were
-   * on <code>http://example.com/admin/post/new</code>, the following redirect to /admin would
-   * land you at <code>http://example.com/admin</code>:
-   *
-   * <pre>
-   *   rsp.redirect("/admin");
-   * </pre>
-   *
-   * Redirects can be relative to the current URL. A redirection of post/new, from
-   * <code>http://example.com/blog/admin/</code> (notice the trailing slash), would give you
-   * <code>http://example.com/blog/admin/post/new.</code>
-   *
-   * <pre>
-   *   rsp.redirect("post/new");
-   * </pre>
-   *
-   * Redirecting to post/new from <code>http://example.com/blog/admin</code> (no trailing slash),
-   * will take you to <code>http://example.com/blog/post/new</code>.
-   *
-   * <p>
-   * If you found the above behavior confusing, think of path segments as directories (have trailing
-   * slashes) and files, it will start to make sense.
-   * </p>
-   *
-   * Pathname relative redirects are also possible. If you were on
-   * <code>http://example.com/admin/post/new</code>, the following redirect would land you at
-   * <code>http//example.com/admin</code>:
-   *
-   * <pre>
-   *   rsp.redirect("..");
-   * </pre>
-   *
-   * A back redirection will redirect the request back to the <code>Referer</code>, defaulting to
-   * <code>/</code> when missing.
-   *
-   * <pre>
-   *   rsp.redirect("back");
-   * </pre>
-   *
-   * @param status A redirect status.
-   * @param location Either a relative or absolute location.
-   * @return A route handler.
-   */
-  public Route.Handler redirect(final Status status, final String location) {
-    requireNonNull(location, "A location is required.");
-    return (req, rsp) -> rsp.redirect(status, location);
-  }
-
   /**
    * Keep track of routes in the order user define them.
    *