jooby-apt: should not generate META-INF/services by default fix #3542

Author: jknack

modules/jooby-apt/src/main/java/io/jooby/apt/JoobyProcessor.java

@@ -34,7 +34,6 @@
   HANDLER,
   DEBUG,
   INCREMENTAL,
-  SERVICES,
   MVC_METHOD,
   RETURN_TYPE,
   ROUTER_PREFIX,
@@ -51,7 +50,6 @@ public interface Options {
     String INCREMENTAL = "jooby.incremental";
     String RETURN_TYPE = "jooby.returnType";
     String MVC_METHOD = "jooby.mvcMethod";
-    String SERVICES = "jooby.services";
     String SKIP_ATTRIBUTE_ANNOTATIONS = "jooby.skipAttributeAnnotations";
 
     static boolean boolOpt(ProcessingEnvironment environment, String option, boolean defaultValue) {
@@ -101,9 +99,6 @@ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment
       if (roundEnv.processingOver()) {
         context.debug("Output:");
         context.getRouters().forEach(it -> context.debug("  %s.java", it.getGeneratedType()));
-        if (context.generateServices()) {
-          doServices(context.getProcessingEnvironment().getFiler(), context.getRouters());
-        }
         return false;
       } else {
         var routeMap = buildRouteRegistry(annotations, roundEnv);
@@ -328,10 +323,7 @@ public Set<String> getSupportedOptions() {
       // more then one originating element is passed to the Filer
       // API on writing the resource file - isolating mode does not
       // allow this.
-      options.add(
-          String.format(
-              "org.gradle.annotation.processing.%s",
-              context.generateServices() ? "aggregating" : "isolating"));
+      options.add("org.gradle.annotation.processing.isolating");
     }
 
     return options;

modules/jooby-apt/src/main/java/io/jooby/internal/apt/MvcContext.java

@@ -29,7 +29,6 @@ private record ResultType(String type, String handler, boolean nonBlocking) {}
   private final ProcessingEnvironment processingEnvironment;
   private final boolean debug;
   private final boolean incremental;
-  private final boolean services;
   private final String routerPrefix;
   private final String routerSuffix;
   private final BiConsumer<Diagnostic.Kind, String> output;
@@ -46,13 +45,11 @@ public MvcContext(
     this.incremental = Options.boolOpt(processingEnvironment, Options.INCREMENTAL, true);
     this.returnType = Options.boolOpt(processingEnvironment, Options.RETURN_TYPE, false);
     this.mvcMethod = Options.boolOpt(processingEnvironment, Options.MVC_METHOD, true);
-    this.services = Options.boolOpt(processingEnvironment, Options.SERVICES, true);
     this.routerPrefix = Options.string(processingEnvironment, Options.ROUTER_PREFIX, "");
     this.routerSuffix = Options.string(processingEnvironment, Options.ROUTER_SUFFIX, "_");
     computeResultTypes(processingEnvironment, handler::put);
 
     debug("Incremental annotation processing is turned %s.", incremental ? "ON" : "OFF");
-    debug("Generation of service provider configuration is turned %s.", services ? "ON" : "OFF");
   }
 
   private void computeResultTypes(
@@ -243,10 +240,6 @@ public Set<TypeElement> superTypes(Element owner) {
     return result;
   }
 
-  public boolean generateServices() {
-    return services;
-  }
-
   public boolean generateMvcMethod() {
     return mvcMethod;
   }