performance: attempt to improve performance

- reset ioThreads to server defaults
- bug fixing on netty buffered output
- reduce call to netty headers set(String, String)

Author: jknack

jooby/src/main/java/io/jooby/ServerOptions.java

@@ -72,7 +72,11 @@ public class ServerOptions {
   private static final String LOCAL_HOST = "0.0.0.0";
 
   /** Number of available threads, but never smaller than <code>2</code>. */
-  public static final int IO_THREADS = Runtime.getRuntime().availableProcessors() * 2;
+  public static final int IO_THREADS =
+      Integer.parseInt(
+          System.getProperty(
+              "jooby.server.ioThreads",
+              Integer.toString(Runtime.getRuntime().availableProcessors())));
 
   /**
    * Number of worker (a.k.a application) threads. It is the number of processors multiply by <code>

jooby/src/main/java/io/jooby/internal/Chi.java

@@ -515,8 +515,6 @@ private interface MethodMatcher {
     StaticRouterMatch get(String method);
 
     void put(String method, StaticRouterMatch route);
-
-    boolean matches(String method);
   }
 
   private static class SingleMethodMatcher implements MethodMatcher {
@@ -531,17 +529,9 @@ public void put(String method, StaticRouterMatch route) {
 
     @Override
     public StaticRouterMatch get(String method) {
-      if (this.method == method) {
-        return route;
-      }
       return this.method.equals(method) ? route : null;
     }
 
-    @Override
-    public boolean matches(String method) {
-      return this.method.equals(method);
-    }
-
     public void clear() {
       this.method = null;
       this.route = null;
@@ -565,11 +555,6 @@ public StaticRouterMatch get(String method) {
     public void put(String method, StaticRouterMatch route) {
       methods.put(method, route);
     }
-
-    @Override
-    public boolean matches(String method) {
-      return this.methods.containsKey(method);
-    }
   }
 
   static class StaticRoute {

jooby/src/test/java/io/jooby/internal/ChiTest.java

@@ -42,6 +42,9 @@ public void staticMap6() {
     router.insert(route("GET", "/4", stringHandler("4")));
     router.insert(route("GET", "/5", stringHandler("5")));
     router.insert(route("GET", "/6", stringHandler("6")));
+
+    Router.Match result = router.find("GET", "/1");
+    assertTrue(result.matches());
   }
 
   @Test

modules/jooby-jetty/src/main/java/io/jooby/jetty/JettyServer.java

@@ -20,6 +20,7 @@
 import org.eclipse.jetty.server.handler.ContextHandler;
 import org.eclipse.jetty.server.handler.gzip.GzipHandler;
 import org.eclipse.jetty.util.DecoratedObjectFactory;
+import org.eclipse.jetty.util.ProcessorUtils;
 import org.eclipse.jetty.util.compression.CompressionPool;
 import org.eclipse.jetty.util.compression.DeflaterPool;
 import org.eclipse.jetty.util.ssl.SslContextFactory;
@@ -47,6 +48,13 @@
 public class JettyServer extends io.jooby.Server.Base {
 
   private static final int THREADS = 200;
+
+  static {
+    int cpus = ProcessorUtils.availableProcessors();
+    var ioThreads = Math.max(1, Math.min(cpus / 2, THREADS / 16));
+    System.setProperty("jooby.server.ioThreads", ioThreads + "");
+  }
+
   private BufferedOutputFactory outputFactory;
 
   private Server server;

modules/jooby-netty/src/main/java/io/jooby/internal/netty/HeadersMultiMap.java

@@ -17,7 +17,6 @@
 import io.netty.handler.codec.DateFormatter;
 import io.netty.handler.codec.http.DefaultHttpHeadersFactory;
 import io.netty.handler.codec.http.HttpHeaders;
-import io.netty.handler.codec.http.HttpHeadersFactory;
 import io.netty.util.AsciiString;
 import io.netty.util.CharsetUtil;
 
@@ -61,20 +60,6 @@ private static CharSequence toValidCharSequence(Object value) {
     }
   }
 
-  public static HttpHeadersFactory httpHeadersFactory() {
-    return new HttpHeadersFactory() {
-      @Override
-      public HttpHeaders newHeaders() {
-        return new HeadersMultiMap();
-      }
-
-      @Override
-      public HttpHeaders newEmptyHeaders() {
-        return new HeadersMultiMap();
-      }
-    };
-  }
-
   @Override
   public int size() {
     return names().size();

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyContext.java

@@ -5,6 +5,7 @@
  */
 package io.jooby.internal.netty;
 
+import static io.jooby.internal.netty.NettyHeadersFactory.HEADERS;
 import static io.netty.buffer.Unpooled.wrappedBuffer;
 import static io.netty.handler.codec.http.HttpHeaderNames.CONTENT_LENGTH;
 import static io.netty.handler.codec.http.HttpHeaderNames.CONTENT_TYPE;
@@ -31,7 +32,6 @@
 import java.nio.charset.Charset;
 import java.security.cert.Certificate;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -75,12 +75,11 @@
 import io.netty.util.IllegalReferenceCountException;
 
 public class NettyContext implements DefaultContext, ChannelFutureListener {
-  public static HttpHeadersFactory HEADERS = HeadersMultiMap.httpHeadersFactory();
   private static final HttpHeaders NO_TRAILING = EmptyHttpHeaders.INSTANCE;
   private static final String STREAM_ID = "x-http2-stream-id";
 
   private String streamId;
-  HttpHeaders setHeaders = HEADERS.newHeaders();
+  HeadersMultiMap setHeaders = HEADERS.newHeaders();
   private int bufferSize;
   InterfaceHttpPostRequestDecoder decoder;
   DefaultHttpDataFactory httpDataFactory;
@@ -286,7 +285,7 @@ public List<Certificate> getClientCertificates() {
     SslHandler sslHandler = (SslHandler) ctx.channel().pipeline().get("ssl");
     if (sslHandler != null) {
       try {
-        return Arrays.asList(sslHandler.engine().getSession().getPeerCertificates());
+        return List.of(sslHandler.engine().getSession().getPeerCertificates());
       } catch (SSLPeerUnverifiedException x) {
         throw SneakyThrows.propagate(x);
       }
@@ -420,13 +419,11 @@ public Context upgrade(@NonNull ServerSentEmitter.Handler handler) {
     responseStarted = true;
     ctx.writeAndFlush(new DefaultHttpResponse(HTTP_1_1, status, setHeaders));
 
-    //    ctx.executor().execute(() -> {
     try {
       handler.handle(new NettyServerSentEmitter(this));
     } catch (Throwable x) {
       sendError(x);
     }
-    //    });
     return this;
   }
 

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyHeadersFactory.java

@@ -0,0 +1,23 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package io.jooby.internal.netty;
+
+import io.netty.handler.codec.http.HttpHeadersFactory;
+
+public class NettyHeadersFactory implements HttpHeadersFactory {
+
+  public static NettyHeadersFactory HEADERS = new NettyHeadersFactory();
+
+  @Override
+  public HeadersMultiMap newHeaders() {
+    return new HeadersMultiMap();
+  }
+
+  @Override
+  public HeadersMultiMap newEmptyHeaders() {
+    return new HeadersMultiMap();
+  }
+}

modules/jooby-netty/src/main/java/io/jooby/netty/NettyServer.java

@@ -6,6 +6,7 @@
 package io.jooby.netty;
 
 import static io.jooby.ServerOptions._4KB;
+import static io.jooby.internal.netty.NettyHeadersFactory.HEADERS;
 import static java.util.concurrent.Executors.newFixedThreadPool;
 
 import java.net.BindException;
@@ -199,8 +200,8 @@ private NettyPipeline newPipeline(
             .setMaxInitialLineLength(_4KB)
             .setMaxHeaderSize(options.getMaxHeaderSize())
             .setMaxChunkSize(options.getBuffer().getSize())
-            .setHeadersFactory(NettyContext.HEADERS)
-            .setTrailersFactory(NettyContext.HEADERS);
+            .setHeadersFactory(HEADERS)
+            .setTrailersFactory(HEADERS);
     return new NettyPipeline(
         sslContext,
         dateService,

modules/jooby-undertow/src/main/java/io/jooby/undertow/UndertowServer.java

@@ -42,6 +42,11 @@
  */
 public class UndertowServer extends Server.Base {
 
+  static {
+    System.setProperty(
+        "jooby.server.ioThreads", (Runtime.getRuntime().availableProcessors() * 2) + "");
+  }
+
   private static final int BACKLOG = 8192;
 
   private static final int _100 = 100;

tests/src/test/java/examples/Performance.java

@@ -0,0 +1,46 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package examples;
+
+import static io.jooby.ExecutionMode.EVENT_LOOP;
+import static io.jooby.MediaType.JSON;
+
+import java.nio.charset.StandardCharsets;
+
+import io.jooby.Jooby;
+import io.jooby.StatusCode;
+import io.jooby.netty.NettyServer;
+
+public class Performance extends Jooby {
+
+  private static final String MESSAGE = "Hello, World!";
+
+  private static final byte[] MESSAGE_BYTES = MESSAGE.getBytes(StandardCharsets.UTF_8);
+
+  {
+    var message = getOutputFactory().wrap(MESSAGE_BYTES);
+    get(
+        "/plaintext",
+        ctx -> {
+          return ctx.send(message);
+        });
+
+    get("/json", ctx -> ctx.setResponseType(JSON).render(new Message(MESSAGE)));
+
+    get("/db", ctx -> ctx.send(StatusCode.OK));
+
+    get("/queries", ctx -> ctx.send(StatusCode.OK));
+
+    get("/fortuxnes", ctx -> ctx.send(StatusCode.OK));
+
+    get("/updates", ctx -> ctx.send(StatusCode.OK));
+  }
+
+  public static void main(final String[] args) {
+    System.setProperty("io.netty.disableHttpHeadersValidation", "true");
+    runApp(args, new NettyServer(), EVENT_LOOP, Performance::new);
+  }
+}