router: clean up

- remove Route.Decorator

Author: jknack

jooby/src/main/java/io/jooby/Body.java

@@ -91,9 +91,9 @@ default Iterator<Value> iterator() {
   long getSize();
 
   /**
-   * Body as readable channel.
+   * Body as a readable channel.
    *
-   * @return Body as readable channel.
+   * @return Body as a readable channel.
    */
   ReadableByteChannel channel();
 

jooby/src/main/java/io/jooby/Jooby.java

@@ -309,9 +309,9 @@ public String getContextPath() {
    * you don't configure the same service twice or more in the main and imported applications too.
    *
    * @param factory Application factory.
-   * @return This application.
+   * @return Created routes.
    */
-  @NonNull public Jooby install(@NonNull SneakyThrows.Supplier<Jooby> factory) {
+  @NonNull public RouteSet install(@NonNull SneakyThrows.Supplier<Jooby> factory) {
     return install("/", factory);
   }
 
@@ -343,13 +343,12 @@ public String getContextPath() {
    *
    * @param path Path prefix.
    * @param factory Application factory.
-   * @return This application.
+   * @return Created routes.
    */
-  @NonNull public Jooby install(@NonNull String path, @NonNull SneakyThrows.Supplier<Jooby> factory) {
+  @NonNull public RouteSet install(@NonNull String path, @NonNull SneakyThrows.Supplier<Jooby> factory) {
     try {
       owner = this;
-      path(path, factory::get);
-      return this;
+      return path(path, factory::get);
     } finally {
       owner = null;
     }

jooby/src/main/java/io/jooby/Route.java

@@ -106,12 +106,6 @@ public void setRoute(Route route) {
     }
   }
 
-  /**
-   * @deprecated use {@link Route.Filter}.
-   */
-  @Deprecated
-  public interface Decorator extends Filter {}
-
   /**
    * Decorates a handler and run logic before handler is executed.
    *

jooby/src/main/java/io/jooby/RouteSet.java

@@ -5,14 +5,9 @@
  */
 package io.jooby;
 
-import static java.util.Collections.EMPTY_LIST;
 import static java.util.Optional.ofNullable;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 import java.util.concurrent.Executor;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
@@ -29,7 +24,7 @@ public class RouteSet {
 
   private List<Route> routes;
 
-  private List<String> tags = EMPTY_LIST;
+  private List<String> tags;
 
   private String summary;
 
@@ -154,7 +149,7 @@ public class RouteSet {
    * @return Route tags.
    */
   public @NonNull List<String> getTags() {
-    return tags;
+    return tags == null ? List.of() : tags;
   }
 
   /**
@@ -164,9 +159,7 @@ public class RouteSet {
    * @return This route.
    */
   public @NonNull RouteSet setTags(@NonNull List<String> tags) {
-    if (this.tags == EMPTY_LIST) {
-      this.tags = new ArrayList<>();
-    }
+    this.tags = tags;
     routes.forEach(it -> tags.forEach(it::addTag));
     return this;
   }

jooby/src/main/java/io/jooby/Router.java

@@ -522,18 +522,6 @@ default Object execute(@NonNull Context context) {
    */
   @NonNull Router use(@NonNull Route.Filter filter);
 
-  /**
-   * Attach a filter to the route pipeline.
-   *
-   * @param filter Filter.
-   * @return This router.
-   * @deprecated Use {@link #use(Route.Filter)}.
-   */
-  @Deprecated
-  default @NonNull Router decorator(@NonNull Route.Decorator filter) {
-    return use(filter);
-  }
-
   /**
    * Add a before route decorator to the route pipeline.
    *