dependency scope of asset processor must be: provided (not test) fix #394

Author: jknack

jooby-assets/src/main/java/org/jooby/assets/AssetProcessor.java

@@ -44,15 +44,15 @@
  *   <dependency>
  *     <groupId>org.jooby</groupId>
  *     <artifactId>jooby-assets-my-processor</artifactId>
- *     <scope>test</scope>
+ *     <scope>provided</scope>
  *   </dependency>
  * </pre>
  *
  * <p>
- * Did you see the <strong>test</strong> scope? We just need the processor for development, because
- * assets are processed on the fly. For <code>prod</code>, assets are processed at built-time via
- * Maven plugin, at runtime we don't need this. This also, helps to keep our dependencies and the
- * jar size to minimum.
+ * Did you see the <strong>provided</strong> scope? We just need the processor for development,
+ * because assets are processed on the fly. For <code>prod</code>, assets are processed at
+ * built-time via Maven plugin, at runtime we don't need this. This also, helps to keep our
+ * dependencies and the jar size to minimum.
  * </p>
  *
  * <p>

jooby-maven-plugin/src/main/java/org/jooby/AssetMojo.java

@@ -43,9 +43,9 @@
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigFactory;
 
-@Mojo(name = "assets", defaultPhase = LifecyclePhase.COMPILE,
-    requiresDependencyResolution = ResolutionScope.TEST)
-@Execute(phase = LifecyclePhase.COMPILE)
+@Mojo(name = "assets", defaultPhase = LifecyclePhase.PREPARE_PACKAGE,
+    requiresDependencyResolution = ResolutionScope.COMPILE)
+@Execute(phase = LifecyclePhase.PREPARE_PACKAGE)
 public class AssetMojo extends AbstractMojo {
 
   @SuppressWarnings("serial")

md/asset-processor.md

@@ -10,11 +10,11 @@ First thing to do is to add the dependency:
   <dependency>
     <groupId>org.jooby</groupId>
     <artifactId>jooby-assets-my-processor</artifactId>
-    <scope>test</scope>
+    <scope>provided</scope>
   </dependency>
 ```
 
-Did you see the **test** scope? We just need the processor for development, because assets are processed on the fly. For ```prod```, assets are processed at built-time via Maven plugin, at runtime we don't need this. This also, helps to keep our dependencies and the jar size to minimum.
+Did you see the **provided** scope? We just need the processor for development, because assets are processed on the fly. For ```prod```, assets are processed at built-time via Maven plugin, so we don't need this library/dependency. This also, helps to keep our dependencies and the jar size to minimum.
 
 Now we have the dependency all we have to do is to add it to our pipeline:
 

md/doc/assets-babel/babel.md

@@ -11,7 +11,7 @@
   <groupId>org.jooby</groupId>
   <artifactId>jooby-assets-babel</artifactId>
   <version>{{version}}</version>
-  <scope>test</scope>
+  <scope>provided</scope>
 </dependency>
 ```
 
@@ -36,7 +36,7 @@ assets {
   <groupId>org.jooby</groupId>
   <artifactId>jooby-assets-babel</artifactId>
   <version>{{version}}</version>
-  <scope>test</scope>
+  <scope>provided</scope>
 </dependency>
 ```
 

md/doc/assets-clean-css/cleancss.md

@@ -11,7 +11,7 @@ A fast, efficient, and well tested CSS minifier, via: <a href="https://github.co
   <groupId>org.jooby</groupId>
   <artifactId>jooby-assets-clean-css</artifactId>
   <version>{{version}}</version>
-  <scope>test</scope>
+  <scope>provided</scope>
 </dependency>
 ```
 

md/doc/assets-closure-compiler/closure-compiler.md

@@ -11,7 +11,7 @@
   <groupId>org.jooby</groupId>
   <artifactId>jooby-assets-closure-compiler</artifactId>
   <version>{{version}}</version>
-  <scope>test</scope>
+  <scope>provided</scope>
 </dependency>
 ```
 

md/doc/assets-csslint/csslint.md

@@ -11,7 +11,7 @@
   <groupId>org.jooby</groupId>
   <artifactId>jooby-assets-csslint</artifactId>
   <version>{{version}}</version>
-  <scope>test</scope>
+  <scope>provided</scope>
 </dependency>
 ```
 

md/doc/assets-jscs/jscs.md

@@ -11,7 +11,7 @@
   <groupId>org.jooby</groupId>
   <artifactId>jooby-assets-jscs</artifactId>
   <version>{{version}}</version>
-  <scope>test</scope>
+  <scope>provided</scope>
 </dependency>
 ```
 

md/doc/assets-jshint/jshint.md

@@ -11,7 +11,7 @@
   <groupId>org.jooby</groupId>
   <artifactId>jooby-assets-jshint</artifactId>
   <version>{{version}}</version>
-  <scope>test</scope>
+  <scope>provided</scope>
 </dependency>
 ```
 

md/doc/assets-less/less.md

@@ -11,7 +11,7 @@
   <groupId>org.jooby</groupId>
   <artifactId>jooby-assets-less</artifactId>
   <version>{{version}}</version>
-  <scope>test</scope>
+  <scope>provided</scope>
 </dependency>
 ```