Skip to content

Commit 161f147

Browse files
committed
refactor: Context: replace call to getRouter.getValueFactory by getValueFactory
1 parent 02a9b6e commit 161f147

4 files changed

Lines changed: 14 additions & 19 deletions

File tree

jooby/src/main/java/io/jooby/internal/SessionImpl.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public Session setId(@Nullable String id) {
7777

7878
@Override
7979
public @NonNull Value get(@NonNull String name) {
80-
return Value.create(ctx.getRouter().getValueFactory(), name, attributes.get(name));
80+
return Value.create(ctx.getValueFactory(), name, attributes.get(name));
8181
}
8282

8383
@Override
@@ -91,9 +91,7 @@ public Session setId(@Nullable String id) {
9191
public @NonNull Value remove(@NonNull String name) {
9292
String value = attributes.remove(name);
9393
updateState();
94-
return value == null
95-
? Value.missing(name)
96-
: Value.value(ctx.getRouter().getValueFactory(), name, value);
94+
return value == null ? Value.missing(name) : Value.value(ctx.getValueFactory(), name, value);
9795
}
9896

9997
@Override

modules/jooby-jetty/src/main/java/io/jooby/internal/jetty/JettyContext.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,15 +202,15 @@ public Context setPathMap(Map<String, String> pathMap) {
202202
@NonNull @Override
203203
public QueryString query() {
204204
if (query == null) {
205-
query = QueryString.create(getRouter().getValueFactory(), request.getHttpURI().getQuery());
205+
query = QueryString.create(getValueFactory(), request.getHttpURI().getQuery());
206206
}
207207
return query;
208208
}
209209

210210
@NonNull @Override
211211
public Formdata form() {
212212
if (formdata == null) {
213-
formdata = Formdata.create(getRouter().getValueFactory());
213+
formdata = Formdata.create(getValueFactory());
214214

215215
formParam(request, formdata);
216216

@@ -251,8 +251,7 @@ public Formdata form() {
251251

252252
@NonNull @Override
253253
public Value header(@NonNull String name) {
254-
return Value.create(
255-
getRouter().getValueFactory(), name, request.getHeaders().getValuesList(name));
254+
return Value.create(getValueFactory(), name, request.getHeaders().getValuesList(name));
256255
}
257256

258257
@NonNull @Override
@@ -262,7 +261,7 @@ public Value header() {
262261
for (HttpField header : request.getHeaders()) {
263262
headerMap.put(header.getName(), header.getValueList());
264263
}
265-
headers = Value.headers(getRouter().getValueFactory(), headerMap);
264+
headers = Value.headers(getValueFactory(), headerMap);
266265
}
267266
return headers;
268267
}

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyContext.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -222,24 +222,23 @@ public QueryString query() {
222222
if (query == null) {
223223
String uri = req.uri();
224224
int q = uri.indexOf('?');
225-
query =
226-
QueryString.create(getRouter().getValueFactory(), q >= 0 ? uri.substring(q + 1) : null);
225+
query = QueryString.create(getValueFactory(), q >= 0 ? uri.substring(q + 1) : null);
227226
}
228227
return query;
229228
}
230229

231230
@NonNull @Override
232231
public Formdata form() {
233232
if (formdata == null) {
234-
formdata = Formdata.create(getRouter().getValueFactory());
233+
formdata = Formdata.create(getValueFactory());
235234
decodeForm(formdata);
236235
}
237236
return formdata;
238237
}
239238

240239
@NonNull @Override
241240
public Value header(@NonNull String name) {
242-
return Value.create(getRouter().getValueFactory(), name, req.headers().getAll(name));
241+
return Value.create(getValueFactory(), name, req.headers().getAll(name));
243242
}
244243

245244
@NonNull @Override
@@ -330,7 +329,7 @@ public Value header() {
330329
for (String name : names) {
331330
headerMap.put(name, headers.getAll(name));
332331
}
333-
this.headers = Value.headers(getRouter().getValueFactory(), headerMap);
332+
this.headers = Value.headers(getValueFactory(), headerMap);
334333
}
335334
return headers;
336335
}

modules/jooby-undertow/src/main/java/io/jooby/internal/undertow/UndertowContext.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ public Context setPort(int port) {
255255

256256
@NonNull @Override
257257
public Value header(@NonNull String name) {
258-
return Value.create(
259-
getRouter().getValueFactory(), name, exchange.getRequestHeaders().get(name));
258+
return Value.create(getValueFactory(), name, exchange.getRequestHeaders().get(name));
260259
}
261260

262261
@NonNull @Override
@@ -269,23 +268,23 @@ public Value header() {
269268
HeaderValues values = map.get(name);
270269
headerMap.put(name.toString(), values);
271270
}
272-
headers = Value.headers(getRouter().getValueFactory(), headerMap);
271+
headers = Value.headers(getValueFactory(), headerMap);
273272
}
274273
return headers;
275274
}
276275

277276
@NonNull @Override
278277
public QueryString query() {
279278
if (query == null) {
280-
query = QueryString.create(getRouter().getValueFactory(), exchange.getQueryString());
279+
query = QueryString.create(getValueFactory(), exchange.getQueryString());
281280
}
282281
return query;
283282
}
284283

285284
@NonNull @Override
286285
public Formdata form() {
287286
if (formdata == null) {
288-
formdata = Formdata.create(getRouter().getValueFactory());
287+
formdata = Formdata.create(getValueFactory());
289288
formData(formdata, exchange.getAttachment(FORM_DATA));
290289
}
291290
return formdata;

0 commit comments

Comments
 (0)