netty: don't send headers twice

Author: jknack

jooby-netty/src/main/java/org/jooby/internal/netty/NettyOutputStream.java

@@ -66,6 +66,8 @@ class NettyOutputStream extends OutputStream {
 
   private HttpHeaders headers;
 
+  private boolean committed;
+
   NettyOutputStream(final NettyResponse rsp, final ChannelHandlerContext ctx, final ByteBuf buffer,
       final boolean keepAlive, final HttpHeaders headers) {
     this.rsp = rsp;
@@ -90,6 +92,10 @@ public void reset() {
     buffer.clear();
   }
 
+  public boolean committed() {
+    return committed;
+  }
+
   @Override
   public void close() throws IOException {
     try {
@@ -163,12 +169,13 @@ public void flush() throws IOException {
         rsp.headers().set(headers);
         ctx.writeAndFlush(rsp).addListener(FIRE_EXCEPTION_ON_FAILURE);
       }
+      committed = true;
       return;
     }
     /**
      * Case 1; we need to send chunks and check if content-length was set or not.
      */
-    if (chunkState == 1) {
+    if (chunkState == 1 && !committed) {
       /**
        * Set headers, if Content-Length wasn't set force/set Transfer-Encoding
        */
@@ -188,6 +195,7 @@ public void flush() throws IOException {
       // send headers
       ctx.write(rsp).addListener(FIRE_EXCEPTION_ON_FAILURE);
     }
+    committed = true;
     /**
      * Write chunk and clear the buffer.
      */

jooby-netty/src/main/java/org/jooby/internal/netty/NettyResponse.java

@@ -124,7 +124,13 @@ public void statusCode(final int code) {
 
   @Override
   public boolean committed() {
-    return ctx == null;
+    if (ctx == null) {
+      return true;
+    }
+    if (out != null) {
+      return out.committed();
+    }
+    return false;
   }
 
   @Override