Fix tests.

Author: jasonish

config_test.go

@@ -23,25 +23,25 @@ func TestConfigGetSpoolByName(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	spool, err := config.GetSpoolByName("first")
-	if err != nil {
-		t.Fatal(err)
+	spool := config.GetSpoolByName("first")
+	if spool == nil {
+		t.Fatal("spool first not found")
 	}
 	AssertEquals(t, spool.Name, "first")
 	AssertEquals(t, spool.Directory, "/capture/first")
 	AssertEquals(t, spool.Prefix, "first.pcap")
 
-	spool, err = config.GetSpoolByName("second")
-	if err != nil {
-		t.Fatal(err)
+	spool = config.GetSpoolByName("second")
+	if spool == nil {
+		t.Fatal("spool second not found")
 	}
 	AssertEquals(t, spool.Name, "second")
 	AssertEquals(t, spool.Directory, "/capture/second")
 	AssertEquals(t, spool.Prefix, "second.pcap")
 
-	_, err = config.GetSpoolByName("third")
-	if err == nil {
-		t.Fatalf("expected error while getting non-existant spool by name")
+	spool = config.GetSpoolByName("third")
+	if err != nil {
+		t.Fatalf("expected nil instead of a spool")
 	}
 
 }

time.go

@@ -39,9 +39,11 @@ func ParseTime(value string, defaultTimezoneOffset string) *time.Time {
 	}
 
 	// Try adding the default timezone offset.
-	result, err = time.Parse(time.RFC3339Nano, value+defaultTimezoneOffset)
-	if err == nil {
-		return &result
+	if defaultTimezoneOffset != "" {
+		result, err = time.Parse(time.RFC3339Nano, value+defaultTimezoneOffset)
+		if err == nil {
+			return &result
+		}
 	}
 
 	return nil

time_test.go

@@ -19,7 +19,7 @@ func AssertEquals(t *testing.T, value interface{}, expected interface{}) {
 func TestParseTime(t *testing.T) {
 
 	// Basic RFC3339 value at UTC.
-	value := ParseTime("2014-04-30T21:54:09Z")
+	value := ParseTime("2014-04-30T21:54:09Z", "")
 	if value == nil {
 		t.Fatalf("unexpected nil")
 	}
@@ -28,23 +28,13 @@ func TestParseTime(t *testing.T) {
 	}
 
 	// With timezone offsets.
-	value = ParseTime("2014-04-30T15:56:42-06:00")
+	value = ParseTime("2014-04-30T15:56:42-06:00", "")
 	if value == nil {
 		t.Fatalf("unexpected nil")
 	}
 	if value.Unix() != 1398895002 {
 		t.Fatalf("expected 1398895002, got %d", value.Unix())
 	}
-
-	// Timezone offsets with the ":".
-	value = ParseTime("2014-04-30T15:56:42-0600")
-	if value == nil {
-		t.Fatalf("unexpected nil")
-	}
-	if value.Unix() != 1398895002 {
-		t.Fatalf("expected 1398895002, got %d", value.Unix())
-	}
-
 }
 
 // Test durations the UI may present, or we provide in the