Accepts only strings or numbers

Author: dellalibera

jsonpointer.js

@@ -52,11 +52,11 @@ function compilePointer (pointer) {
     if (pointer[0] === '') return pointer
     throw new Error('Invalid JSON pointer.')
   } else if (Array.isArray(pointer)) {
-    pointer.forEach(function (part, i) {
+    for (const part of pointer) {
       if (typeof part !== 'string' && typeof part !== 'number') {
-        pointer[i] = '' + part
+        throw new Error('Invalid JSON pointer.')
       }
-    })
+    }
     return pointer
   }
 

test.js

@@ -144,41 +144,20 @@ jsonpointer.set({}, '/foo/__proto__/__proto__/boo', 'polluted')
 assert(!d.boo, 'should not boo')
 
 var e = {}
-jsonpointer.set({}, '/constructor/prototype/boo', 'polluted')
-assert(!e.boo, 'should not boo')
-
 jsonpointer.set({}, '/foo/constructor/prototype/boo', 'polluted')
 assert(!e.boo, 'should not boo')
 
 jsonpointer.set({}, '/foo/constructor/constructor/prototype/boo', 'polluted')
 assert(!e.boo, 'should not boo')
 
-var f = {}
-jsonpointer.set({}, [['__proto__'], 'boo'], 'polluted')
-assert(!f.boo, 'should not f.boo')
-
-jsonpointer.set({}, [[['__proto__']], 'boo'], 'polluted')
-assert(!f.boo, 'should not f.boo')
-
-jsonpointer.set({}, [['__proto__'], ['__proto__'], 'boo'], 'polluted')
-assert(!f.boo, 'should not f.boo')
-
-jsonpointer.set({}, [[['__proto__']], [['__proto__']], 'boo'], 'polluted')
-assert(!f.boo, 'should not f.boo')
-
-jsonpointer.set({}, [['__proto__'], ['__proto__'], ['__proto__'], 'boo'], 'polluted')
-assert(!f.boo, 'should not f.boo')
-
-jsonpointer.set({}, [['foo'], ['__proto__'], 'boo'], 'polluted')
-assert(!f.boo, 'should not boo')
-
-jsonpointer.set({}, [['foo'], ['__proto__'], ['__proto__'], 'boo'], 'polluted')
-assert(!f.boo, 'should not boo')
-
-jsonpointer.set({}, [['constructor'], ['prototype'], 'boo'], 'polluted')
-assert(!f.boo, 'should not boo')
-
-jsonpointer.set({}, [['constructor'], ['constructor'], ['prototype'], 'boo'], 'polluted')
-assert(!f.boo, 'should not boo')
+assert.throws(function () { jsonpointer.set({}, [['__proto__'], 'boo'], 'polluted')}, validateError)
+assert.throws(function () { jsonpointer.set({}, [[['__proto__']], 'boo'], 'polluted')}, validateError)
+assert.throws(function () { jsonpointer.set({}, [['__proto__'], ['__proto__'], 'boo'], 'polluted')}, validateError)
+assert.throws(function () { jsonpointer.set({}, [[['__proto__']], [['__proto__']], 'boo'], 'polluted')}, validateError)
+assert.throws(function () { jsonpointer.set({}, [['__proto__'], ['__proto__'], ['__proto__'], 'boo'], 'polluted')}, validateError)
+assert.throws(function () { jsonpointer.set({}, [['foo'], ['__proto__'], 'boo'], 'polluted')}, validateError)
+assert.throws(function () { jsonpointer.set({}, [['foo'], ['__proto__'], ['__proto__'], 'boo'], 'polluted')}, validateError)
+assert.throws(function () { jsonpointer.set({}, [['constructor'], ['prototype'], 'boo'], 'polluted')}, validateError)
+assert.throws(function () { jsonpointer.set({}, [['constructor'], ['constructor'], ['prototype'], 'boo'], 'polluted')}, validateError)
 
 console.log('All tests pass.')