Skip to content

Commit 569e18d

Browse files
committed
add mix format in CI
1 parent 749a977 commit 569e18d

4 files changed

Lines changed: 13 additions & 16 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,9 @@ jobs:
114114
run: mix credo --all --strict
115115
if: ${{ matrix.lint }}
116116

117-
# TODO: how do we fix problem in Github Actions? there's some weird
118-
# thing where it just throws format error even though mix format
119-
# is ran multiple times locally!
120-
# - name: Check format files
121-
# run: mix format --check-formatted
122-
# if: ${{ matrix.lint }}
117+
- name: Check format files
118+
run: mix format --check-formatted
119+
if: ${{ matrix.lint }}
123120

124121
- name: Run tests
125122
run: mix test --only ${{ matrix.typesense }} --trace

docker-compose.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
services:
22
typesense:
3-
# image: docker.io/typesense/typesense:27.1
4-
image: docker.io/typesense/typesense:0.25.2
5-
# image: docker.io/typesense/typesense:26.0
3+
image: docker.io/typesense/typesense:27.1
64
container_name: typesense
75
restart: on-failure
86
ports:

lib/open_api_typesense/client.ex

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ defmodule OpenApiTypesense.Client do
123123
|> Req.Request.put_header("x-typesense-api-key", api_key())
124124
|> Req.Request.run_request()
125125

126-
parse_resp(resp, opts.response)
126+
parse_resp(resp, opts[:response])
127127
end
128128

129129
defp parse_resp(%Req.TransportError{} = error, _opts_resp) do
@@ -156,8 +156,13 @@ defmodule OpenApiTypesense.Client do
156156
resp =
157157
values
158158
|> Enum.map(fn {module, _func_name} ->
159-
struct(module, body)
159+
if is_map(module),
160+
do: struct(body, module)
160161
end)
162+
|> case do
163+
[nil] -> []
164+
resp -> resp
165+
end
161166

162167
{status, resp}
163168
end

test/operations/collections_test.exs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,8 @@ defmodule CollectionsTest do
3434
end
3535

3636
@tag ["27.1": true, "26.0": true, "0.25.2": true]
37-
test "success: list empty collection", %{schema: schema} do
38-
Collections.delete_collection(schema.name)
39-
40-
assert {:ok, [%CollectionResponse{name: nil, created_at: nil}]} =
41-
Collections.get_collections()
37+
test "success: list collections", %{schema: schema} do
38+
assert {:ok, []} = Collections.get_collections()
4239
end
4340

4441
@tag ["27.1": true, "26.0": true, "0.25.2": true]

0 commit comments

Comments
 (0)