Skip to content

Commit 55c1028

Browse files
committed
fix: showing no funders message issue properly
1 parent 17b9de8 commit 55c1028

4 files changed

Lines changed: 14 additions & 12 deletions

File tree

src/app/components/EditorFundedBy.tsx

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ const subfields = ["name", "uri"] as const satisfies Readonly<
1414
>;
1515

1616
export default function EditorFundedBy(): JSX.Element {
17+
const { t } = useTranslation();
18+
1719
const { control, register } = useFormContext<PublicCode, typeof fieldName>();
1820
const { append, fields, remove } = useFieldArray<
1921
PublicCode,
@@ -31,8 +33,6 @@ export default function EditorFundedBy(): JSX.Element {
3133
name: fieldName,
3234
});
3335

34-
const { t } = useTranslation();
35-
3636
return (
3737
<div className="mb-0">
3838
<div className="position-relative">
@@ -41,9 +41,11 @@ export default function EditorFundedBy(): JSX.Element {
4141
</label>
4242
</div>
4343
<div className="ms-2">
44-
{field.value?.length === 0 ? (
44+
{field.value === undefined ||
45+
field.value === null ||
46+
field.value.length === 0 ? (
4547
<p>
46-
<small>{t("editor.form.noFunders")}</small>
48+
<small>{t("editor.noFunders")}</small>
4749
</p>
4850
) : (
4951
<Table responsive>
@@ -65,7 +67,7 @@ export default function EditorFundedBy(): JSX.Element {
6567
<th scope="row">{index + 1}</th>
6668
{subfields.map((subfield) => {
6769
const { ref, ...reg } = register(
68-
`${fieldName}.${index}.${subfield}`
70+
`${fieldName}.${index}.${subfield}`,
6971
);
7072

7173
return (
@@ -80,7 +82,7 @@ export default function EditorFundedBy(): JSX.Element {
8082
}
8183
validationText={get(
8284
errors,
83-
`${fieldName}.${index}.${subfield}.message`
85+
`${fieldName}.${index}.${subfield}.message`,
8486
)}
8587
/>
8688
</td>

src/i18n/locales/de.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@
6363
"overwritetext": "Diese Operation löscht alle Daten",
6464
"unset": "(nicht gesetzt)",
6565
"true": "Ja",
66-
"false": "Nein",
67-
"noFunders": "Keine Förderer vorhanden"
66+
"false": "Nein"
6867
},
68+
"noFunders": "Keine Förderer vorhanden",
6969
"sections": {
7070
"name": "Name",
7171
"repository-and-documentation": "Repository & Dokumentation",

src/i18n/locales/it.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@
7979
"overwritetext": "Questa operazione cancellerà tutti i dati già inseriti",
8080
"unset": "(Non impostato)",
8181
"true": "",
82-
"false": "No",
83-
"noFunders": "Nessun finanziatore presente"
82+
"false": "No"
8483
},
84+
"noFunders": "Nessun finanziatore presente",
8585
"sections": {
8686
"name": "Nome",
8787
"repository-and-documentation": "Repository & Documentazione",

src/i18n/locales/nl.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@
7878
"overwritetext": "Deze bewerking zal alle gegevens wissen",
7979
"unset": "(niet ingesteld)",
8080
"true": "Ja",
81-
"false": "Nee",
82-
"noFunders": "Geen financiers aanwezig"
81+
"false": "Nee"
8382
},
83+
"noFunders": "Geen financiers aanwezig",
8484
"sections": {
8585
"name": "Naam",
8686
"repository-and-documentation": "Repository & Documentatie",

0 commit comments

Comments
 (0)