Merge pull request #759 from ipython/pre-commit-ci-update-config

Author: blink1073

.pre-commit-config.yaml

@@ -52,32 +52,28 @@ repos:
       - id: prettier
 
   - repo: https://github.com/asottile/pyupgrade
-    rev: v2.37.2
+    rev: v2.37.3
     hooks:
       - id: pyupgrade
         args: [--py37-plus]
 
   - repo: https://github.com/PyCQA/doc8
-    rev: 0.11.2
+    rev: v1.0.0
     hooks:
       - id: doc8
         args: [--max-line-length=200]
         stages: [manual]
 
   - repo: https://github.com/pycqa/flake8
-    rev: 4.0.1
+    rev: 5.0.2
     hooks:
       - id: flake8
         additional_dependencies:
-          [
-            "flake8-bugbear==20.1.4",
-            "flake8-logging-format==0.6.0",
-            "flake8-implicit-str-concat==0.2.0",
-          ]
+          ["flake8-bugbear==22.6.22", "flake8-implicit-str-concat==0.2.0"]
         stages: [manual]
 
   - repo: https://github.com/pre-commit/mirrors-eslint
-    rev: v8.20.0
+    rev: v8.21.0
     hooks:
       - id: eslint
         stages: [manual]

traitlets/config/application.py

@@ -830,12 +830,12 @@ def _load_config_files(cls, basefilename, path=None, log=None, raise_config_file
 
         if not isinstance(path, list):
             path = [path]
-        for path in path[::-1]:
+        for current in reversed(path):
             # path list is in descending priority order, so load files backwards:
-            pyloader = cls.python_config_loader_class(basefilename + ".py", path=path, log=log)
+            pyloader = cls.python_config_loader_class(basefilename + ".py", path=current, log=log)
             if log:
-                log.debug("Looking for %s in %s", basefilename, path or os.getcwd())
-            jsonloader = cls.json_config_loader_class(basefilename + ".json", path=path, log=log)
+                log.debug("Looking for %s in %s", basefilename, current or os.getcwd())
+            jsonloader = cls.json_config_loader_class(basefilename + ".json", path=current, log=log)
             loaded: t.List[t.Any] = []
             filenames: t.List[str] = []
             for loader in [pyloader, jsonloader]:
@@ -882,17 +882,17 @@ def load_config_file(self, filename, path=None):
         """Load config files by filename and path."""
         filename, ext = os.path.splitext(filename)
         new_config = Config()
-        for (config, filename) in self._load_config_files(
+        for (config, fname) in self._load_config_files(
             filename,
             path=path,
             log=self.log,
             raise_config_file_errors=self.raise_config_file_errors,
         ):
             new_config.merge(config)
             if (
-                filename not in self._loaded_config_files
+                fname not in self._loaded_config_files
             ):  # only add to list of loaded files if not previously loaded
-                self._loaded_config_files.append(filename)
+                self._loaded_config_files.append(fname)
         # add self.cli_config to preserve CLI config priority
         new_config.merge(self.cli_config)
         self.update_config(new_config)