Merge pull request #737 from blink1073/fix-typings

Author: blink1073

traitlets/tests/test_traitlets.py

@@ -56,6 +56,7 @@
     link,
     observe,
     observe_compat,
+    traitlets,
     validate,
 )
 from traitlets.utils import cast_unicode
@@ -3133,3 +3134,17 @@ def test_object_from_string(s, expected):
 )
 def test_tcp_from_string(s, expected):
     _from_string_test(TCPAddress, s, expected)
+
+
+def test_all_attribute():
+    """Verify all trait types are added to `traitlets.__all__`"""
+    names = dir(traitlets)
+    for name in names:
+        value = getattr(traitlets, name)
+        if not name.startswith("_") and isinstance(value, type) and issubclass(value, TraitType):
+            if name not in traitlets.__all__:
+                raise ValueError(f"{name} not in __all__")
+
+    for name in traitlets.__all__:
+        if name not in names:
+            raise ValueError(f"{name} should be removed from __all__")

traitlets/traitlets.py

@@ -74,6 +74,7 @@
     "CComplex",
     "CFloat",
     "CInt",
+    "CLong",
     "CRegExp",
     "CUnicode",
     "Callable",
@@ -95,7 +96,9 @@
     "HasTraits",
     "Instance",
     "Int",
+    "Integer",
     "List",
+    "Long",
     "MetaHasDescriptors",
     "MetaHasTraits",
     "ObjectName",
@@ -3455,16 +3458,3 @@ def validate(self, obj, value):
             return value
         else:
             self.error(obj, value)
-
-
-def _add_all():
-    """add all trait types to `__all__`
-
-    do in a function to avoid iterating through globals while defining local variables
-    """
-    for _name, _value in globals().items():
-        if not _name.startswith("_") and isinstance(_value, type) and issubclass(_value, TraitType):
-            __all__.append(_name)
-
-
-_add_all()