Modified test_notebooks

Author: ipeirotis

binder/test_notebooks.py

@@ -2,47 +2,32 @@
 
 import sys
 import subprocess
-import tempfile
 import nbformat
 
 from os import listdir
-from os.path import isfile, join, isdir
+from os.path import isfile, join
 
 
-def notebook_run(path):
-    """Execute a notebook via nbconvert and collect output.
-       :returns (parsed nb object, execution errors)
-    """
-
-    with tempfile.NamedTemporaryFile(suffix=".ipynb") as fout:
-        args = ["jupyter", "nbconvert", "--to", "notebook", "--execute",
-          "--ExecutePreprocessor.timeout=600",
-          "--output", fout.name, path]
-        subprocess.check_call(args)
-
-        fout.seek(0)
-        nb = nbformat.read(fout.name, nbformat.current_nbformat)
-
-    errors = [output for cell in nb.cells if "outputs" in cell
-                     for output in cell["outputs"]\
-                     if output.output_type == "error"]
-
-    return nb, errors
+def test_notebooks(path):
 
+    notebooks = [
+        f for f in listdir(path) if isfile(join(path, f)) and f.endswith(".ipynb")
+    ]
 
-def test_notebooks(path):
-    
-    notebooks = [f for f in listdir(path) if isfile(join(path, f)) and f.endswith('.ipynb') and f!='test_notebooks']
-    directories = [f for f in listdir(path) if isdir(join(path, f))]
-    
     for notebook in sorted(notebooks):
         print(notebook)
-        _, errors = notebook_run(join(path, notebook))
-        if errors != []:
+        args = [
+            "jupyter",
+            "nbconvert",
+            "--to",
+            "notebook",
+            "--execute",
+            "--ExecutePreprocessor.timeout=600",
+            join(path, notebook),
+        ]
+        exit_code = subprocess.check_call(args)
+        if exit_code != 0:
             raise AssertionError
-    
-    for directory in sorted(directories):
-        print(directory)
 
 
 def main():
@@ -51,4 +36,4 @@ def main():
 
 
 if __name__ == "__main__":
-    main()
+    main()