Skip to content

Commit bb27ecf

Browse files
committed
replaced print stacktrace with log
1 parent f69eb7d commit bb27ecf

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/main/java/io/ipdata/client/service/ApiErrorDecoder.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@
1010
import java.io.IOException;
1111
import java.net.URL;
1212
import lombok.RequiredArgsConstructor;
13+
import lombok.extern.slf4j.Slf4j;
1314
import org.slf4j.Logger;
1415

15-
@RequiredArgsConstructor
16+
@RequiredArgsConstructor @Slf4j
1617
public class ApiErrorDecoder implements ErrorDecoder {
1718
private static final int RATE_LIMIT_STATUS = 403;
1819
private final ObjectMapper mapper;
@@ -35,7 +36,7 @@ public Exception decode(String methodKey, Response response) {
3536
return new RemoteIpdataException(error.getMessage(), response.status());
3637
}
3738
} catch (IOException ioException) {
38-
ioException.printStackTrace();
39+
log.error(ioException.getMessage(), ioException);
3940
return new RemoteIpdataException(message, response.status());
4041
}
4142
}

src/main/java/io/ipdata/client/service/ApiKeyRequestInterceptor.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
import feign.RequestTemplate;
66
import java.io.InputStreamReader;
77
import lombok.RequiredArgsConstructor;
8+
import lombok.extern.slf4j.Slf4j;
89

9-
@RequiredArgsConstructor
10+
@RequiredArgsConstructor @Slf4j
1011
class ApiKeyRequestInterceptor implements RequestInterceptor {
1112

1213
private static final String API_KEY_PARAM = "api-key";
@@ -21,7 +22,7 @@ class ApiKeyRequestInterceptor implements RequestInterceptor {
2122
.getResourceAsStream("/VERSION"))).replaceAll("\\n","");
2223
version = String.format("io.ipdata.client.java.%s", version);
2324
}catch (Exception e){
24-
e.printStackTrace();
25+
log.error(e.getMessage(), e);
2526
version = "io.ipdata.client.java.UNKNOWN";
2627
}
2728
API_CLIENT_VALUE = version;

0 commit comments

Comments
 (0)