Skip to content

Commit 604676a

Browse files
committed
Fix failing tests
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
1 parent 73be2ef commit 604676a

3 files changed

Lines changed: 6 additions & 20 deletions

File tree

docs/source/notebooks/DiCE_multiclass_classification_and_regression.ipynb

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@
162162
"outputs": [],
163163
"source": [
164164
"# Single input\n",
165-
"query_instances_iris = x_train[2:3]\n",
165+
"query_instances_iris = x_test[2:3]\n",
166166
"genetic_iris = exp_genetic_iris.generate_counterfactuals(query_instances_iris, total_CFs=7, desired_class=2)\n",
167167
"genetic_iris.visualize_as_dataframe()"
168168
]
@@ -174,7 +174,7 @@
174174
"outputs": [],
175175
"source": [
176176
"# Multiple queries can be given as input at once\n",
177-
"query_instances_iris = x_train[17:19]\n",
177+
"query_instances_iris = x_test[17:19]\n",
178178
"genetic_iris = exp_genetic_iris.generate_counterfactuals(query_instances_iris, total_CFs=7, desired_class=2)\n",
179179
"genetic_iris.visualize_as_dataframe(show_only_changes=True)"
180180
]
@@ -275,7 +275,7 @@
275275
"metadata": {},
276276
"outputs": [],
277277
"source": [
278-
"exp_genetic_housing = Dice(d_housing, m_housing, method=\"random\")"
278+
"exp_genetic_housing = Dice(d_housing, m_housing, method=\"genetic\")"
279279
]
280280
},
281281
{
@@ -292,25 +292,12 @@
292292
"outputs": [],
293293
"source": [
294294
"# Multiple queries can be given as input at once\n",
295-
"query_instances_housing = x_train[2:3]\n",
295+
"query_instances_housing = x_test[2:4]\n",
296296
"genetic_housing = exp_genetic_housing.generate_counterfactuals(query_instances_housing,\n",
297297
" total_CFs=2,\n",
298-
" features_to_vary=[\"AveRooms\"],\n",
299298
" desired_range=[3.0, 5.0])\n",
300299
"genetic_housing.visualize_as_dataframe(show_only_changes=True)"
301300
]
302-
},
303-
{
304-
"cell_type": "code",
305-
"execution_count": null,
306-
"metadata": {},
307-
"outputs": [],
308-
"source": [
309-
"# Multiple queries can be given as input at once\n",
310-
"query_instances_housing = x_train[17:19]\n",
311-
"genetic_housing = exp_genetic_housing.generate_counterfactuals(query_instances_housing, total_CFs=4, desired_range=[40, 50])\n",
312-
"genetic_housing.visualize_as_dataframe(show_only_changes=True)"
313-
]
314301
}
315302
],
316303
"metadata": {

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,4 +226,4 @@ def create_housing_data():
226226
test_size=0.2, random_state=7)
227227
x_train = pd.DataFrame(data=x_train, columns=housing.feature_names)
228228
x_test = pd.DataFrame(data=x_test, columns=housing.feature_names)
229-
return x_train, x_test, y_train, y_test, housing.feature_names.tolist()
229+
return x_train, x_test, y_train, y_test, housing.feature_names

tests/test_dice_interface/test_explainer_base.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ def test_zero_totalcfs(self, desired_range, regression_exp_object, sample_custom
398398
desired_range=desired_range)
399399

400400
@pytest.mark.parametrize("desired_range, method",
401-
[([10, 100], 'random')])
401+
[([3, 5], 'random')])
402402
def test_numeric_categories(self, desired_range, method, create_housing_data):
403403
x_train, x_test, y_train, y_test, feature_names = \
404404
create_housing_data
@@ -409,7 +409,6 @@ def test_numeric_categories(self, desired_range, method, create_housing_data):
409409

410410
dataset_train = x_train.copy()
411411
dataset_train['Outcome'] = y_train
412-
feature_names.remove('CHAS')
413412

414413
d = dice_ml.Data(dataframe=dataset_train, continuous_features=feature_names, outcome_name='Outcome')
415414
m = dice_ml.Model(model=model, backend='sklearn', model_type='regressor')

0 commit comments

Comments
 (0)