Make search facets fully asynchronous (#12262)

* Make search facets fully asynchronous by updating search functions and imports

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add missing await in searchfacets partials

* Update parameters for async update

* Add tests for /partials/SearchFacets.json endpoint with async mocks

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Refactor SearchFacetsPartial to support asynchronous generation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* precommit on upgrading searchfacetspartial to async

* Revert unintended vendor/infogami submodule update

* Delete openlibrary/tests/fastapi/test_search_facets_partial.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Raymond Berger <RayBB@users.noreply.github.com>

Author: 3 people

openlibrary/fastapi/partials.py

@@ -42,14 +42,13 @@ async def search_facets_partial(
     - param: dict with search parameters (q, author_key, subject_facet, etc.)
     - path: str (e.g., '/search')
     - query: str (e.g., '?q=python')
-    # TODO: Make this fully async
     """
     try:
         parsed_data = json.loads(data)
     except json.JSONDecodeError:
         raise HTTPException(status_code=400, detail="Invalid JSON in data parameter")
 
-    return SearchFacetsPartial(data=parsed_data, sfw=sfw == "yes").generate()
+    return await SearchFacetsPartial(data=parsed_data, sfw=sfw == "yes").generate_async()
 
 
 @router.get("/partials/AffiliateLinks.json", include_in_schema=SHOW_PARTIALS_IN_SCHEMA)

openlibrary/plugins/openlibrary/partials.py

@@ -12,7 +12,7 @@
 from openlibrary.i18n import gettext as _
 from openlibrary.plugins.openlibrary.lists import get_lists_async, get_user_lists
 from openlibrary.plugins.upstream.yearly_reading_goals import get_reading_goals
-from openlibrary.plugins.worksearch.code import do_search, work_search
+from openlibrary.plugins.worksearch.code import do_search_async, work_search
 from openlibrary.plugins.worksearch.subjects import (
     date_range_to_publish_year_filter,
     get_subject,
@@ -218,13 +218,16 @@ def __init__(self, data: dict, sfw: bool = False):
         )
 
     def generate(self) -> dict:
+        raise NotImplementedError("Use generate_async instead")
+
+    async def generate_async(self) -> dict:
         path = self.data.get('path')
         query = self.data.get('query', '')
         parsed_qs = parse_qs(query.replace('?', ''))
         param = self.data.get('param', {})
 
         sort = None
-        search_response = do_search(
+        search_response = await do_search_async(
             param,
             sort,
             rows=0,

openlibrary/plugins/worksearch/code.py

@@ -544,7 +544,7 @@ def get_matches(fragment: str) -> set[str]:
         return highlighting or None
 
 
-def do_search(
+async def do_search_async(
     param: dict,
     sort: str | None,
     page=1,
@@ -576,13 +576,13 @@ def do_search(
     if sfw:
         fields |= {'subject'}
 
-    return run_solr_query(
+    return await run_solr_query_async(
         WorkSearchScheme(),
         param,
-        rows,
-        page,
-        sort,
-        spellcheck_count,
+        rows=rows,
+        page=page,
+        sort=sort,
+        spellcheck_count=spellcheck_count,
         fields=list(fields),
         facet=facet,
         highlight=highlight,
@@ -591,6 +591,9 @@ def do_search(
     )
 
 
+do_search = async_bridge.wrap(do_search_async)
+
+
 def get_doc(doc: SolrDocument):
     """
     Coerce a solr document to look more like an Open Library edition/work. Ish.