fix: move PLC0415 inline imports to top-level in 11 test/config files (#12295)

Co-authored-by: RayBB <RayBB@users.noreply.github.com>

Author: shoaib-inamdar

openlibrary/conftest.py

@@ -3,6 +3,7 @@
 import pytest
 import web
 
+from infogami import config
 from infogami.infobase.tests.pytest_wildcard import Wildcard
 from infogami.utils import template
 from infogami.utils.view import render_template as infobase_render_template
@@ -15,6 +16,7 @@
 from openlibrary.mocks.mock_memcache import (
     mock_memcache,  # noqa: F401 side effects may be needed
 )
+from openlibrary.utils.request_context import RequestContextVars, req_context
 
 
 @pytest.fixture(autouse=True)
@@ -54,10 +56,6 @@ def setup_db_config():
     which is necessary for the context variable infrastructure being added. Without this, tests may fail due to
     missing or incorrect database parameters when initializing site.
     """
-    import web
-
-    from infogami import config
-
     # Set web.config.db_parameters for OLConnection
     web.config.db_parameters = {}
 
@@ -89,7 +87,6 @@ def request_context_fixture():
     Provides defaults and allows tests to override any subset of fields.
     Automatically cleans up after the test.
     """
-    from openlibrary.utils.request_context import RequestContextVars, req_context
 
     tokens = []
 
@@ -149,12 +146,12 @@ def render_template(request):
 
     # ol_infobase.init_plugin call is failing when trying to import plugins.openlibrary.code.
     # monkeypatch to avoid that.
-    from openlibrary.plugins import ol_infobase
+    from openlibrary.plugins import ol_infobase  # noqa: PLC0415
 
     init_plugin = ol_infobase.init_plugin
     ol_infobase.init_plugin = lambda: None
 
-    from openlibrary.plugins.openlibrary import code
+    from openlibrary.plugins.openlibrary import code  # noqa: PLC0415
 
     web.config.db_parameters = {}
     code.setup_template_globals()

openlibrary/plugins/admin/tests/test_services.py

@@ -2,17 +2,18 @@
 Tests for the services module used by the admin interface.
 """
 
+from .. import services
+
 
 def test_loader(serviceconfig):
     "Make sure services are loaded"
-    from .. import services
 
-    services = services.load_all(serviceconfig, "http://nagios.url")
-    assert len(list(services)) == 2
-    s = sorted(services)
+    loaded_services = services.load_all(serviceconfig, "http://nagios.url")
+    assert len(list(loaded_services)) == 2
+    s = sorted(loaded_services)
     assert s[0] == "ol-web0"
     assert s[1] == "ol-web1"
-    assert services["ol-web0"][0].name == "7071-ol-gunicorn"
-    assert services["ol-web0"][1].name == "7060-memcached"
-    assert services["ol-web1"][0].name == "7072-ol-gunicorn"
-    assert services["ol-web1"][1].name == "7061-memcached"
+    assert loaded_services["ol-web0"][0].name == "7071-ol-gunicorn"
+    assert loaded_services["ol-web0"][1].name == "7060-memcached"
+    assert loaded_services["ol-web1"][0].name == "7072-ol-gunicorn"
+    assert loaded_services["ol-web1"][1].name == "7061-memcached"

openlibrary/plugins/upstream/tests/test_merge_authors.py

@@ -1,6 +1,7 @@
 import web
 
 from infogami.infobase import client, common
+from openlibrary.plugins.upstream import models
 from openlibrary.plugins.upstream.merge_authors import (
     AuthorMergeEngine,
     AuthorRedirectEngine,
@@ -16,10 +17,8 @@
 def setup_module(mod):
     # delegate.fakeload()
 
-    # models module imports openlibrary.code, which imports ol_infobase and that expects db_parameters.
+    # Configure test database settings before calling models.setup().
     web.config.db_parameters = {"dbn": "sqlite", "db": ":memory:"}
-    from openlibrary.plugins.upstream import models
-
     models.setup()
 
 

openlibrary/plugins/upstream/tests/test_utils.py

@@ -1,8 +1,10 @@
 from collections.abc import Sequence
+from unittest.mock import MagicMock, patch
 
 import pytest
 import web
 
+from infogami import config
 from openlibrary.catalog.add_book.tests.conftest import add_languages  # noqa: F401
 from openlibrary.mocks.mock_infobase import MockSite
 
@@ -133,8 +135,6 @@ def test_canonical_url():
 
 
 def test_get_coverstore_url(monkeypatch):
-    from infogami import config
-
     monkeypatch.delattr(config, "coverstore_url", raising=False)
     assert utils.get_coverstore_url() == "https://covers.openlibrary.org"
 
@@ -342,8 +342,6 @@ def test_render_cached_macro_evicts_cache_on_error(monkeypatch):
     `work_search` returned a Solr error in RawQueryCarousel), the bad result
     must be evicted from memcache so subsequent requests get a fresh attempt.
     """
-    from unittest.mock import MagicMock, patch
-
     # Simulate the rendered macro result indicating failure
     error_page = {"do_not_cache": "True", "content": "<div></div>"}
 

openlibrary/plugins/worksearch/schemes/tests/test_works.py

@@ -1,6 +1,7 @@
 from unittest.mock import patch
 
 import pytest
+import web
 
 from openlibrary.plugins.worksearch.schemes.works import WorkSearchScheme
 
@@ -136,8 +137,6 @@ def test_process_user_query(query, parsed_query):
 
 @pytest.mark.parametrize(("query", "edQuery"), EDITION_KEY_TESTS.items())
 def test_q_to_solr_params_edition_key(query, edQuery):
-    import web
-
     web.ctx.lang = "en"
     s = WorkSearchScheme()
 

openlibrary/plugins/worksearch/tests/test_autocomplete.py

@@ -3,7 +3,7 @@
 
 import web
 
-from openlibrary.plugins.worksearch.autocomplete import autocomplete, works_autocomplete
+from openlibrary.plugins.worksearch.autocomplete import autocomplete, series_autocomplete, works_autocomplete
 from openlibrary.utils.solr import Solr
 
 
@@ -106,8 +106,6 @@ def test_works_autocomplete():
 
 
 def test_series_autocomplete_olid():
-    from openlibrary.plugins.worksearch.autocomplete import series_autocomplete
-
     ac = series_autocomplete()
     with (
         patch("web.input") as mock_web_input,
@@ -124,8 +122,6 @@ def test_series_autocomplete_olid():
 
 
 def test_series_autocomplete_url():
-    from openlibrary.plugins.worksearch.autocomplete import series_autocomplete
-
     ac = series_autocomplete()
     with (
         patch("web.input") as mock_web_input,

openlibrary/tests/core/test_models.py

@@ -1,6 +1,8 @@
 import pytest
+import web
 
 from openlibrary.core import models
+from openlibrary.mocks import mock_infobase
 
 
 class MockSite:
@@ -151,10 +153,6 @@ def test_resolve_redirect_chain(self, monkeypatch):
         work3 = {"key": work3_key, "location": work4_key, "type": type_redir}
         work4 = {"key": work4_key, "type": type_work}
 
-        import web
-
-        from openlibrary.mocks import mock_infobase
-
         site = mock_infobase.MockSite()
         site.save(web.storage(work1))
         site.save(web.storage(work2))

openlibrary/tests/fastapi/conftest.py

@@ -6,13 +6,14 @@
 from fastapi.testclient import TestClient
 
 from openlibrary.fastapi.auth import AuthenticatedUser, require_authenticated_user
+from openlibrary.plugins.worksearch.code import SearchResponse
 
 
 @pytest.fixture
 def fastapi_client():
     """Create a test client for the FastAPI app."""
     with patch("openlibrary.asgi_app.set_context_from_fastapi", autospec=True):
-        from openlibrary.asgi_app import create_app
+        from openlibrary.asgi_app import create_app  # noqa: PLC0415
 
         app = create_app()
         client = TestClient(app)
@@ -126,7 +127,6 @@ def _default_search_response():
 
 def _default_subjects_response():
     """Default mock response for subjects search."""
-    from openlibrary.plugins.worksearch.code import SearchResponse
 
     return SearchResponse(
         facet_counts=None,

openlibrary/tests/fastapi/test_search.py

@@ -1,6 +1,7 @@
 """Basic tests for the FastAPI search endpoint."""
 
 import json
+from urllib.parse import urlencode
 
 import pytest
 
@@ -28,8 +29,6 @@ def search(client, **params):
     This helper provides a cleaner interface for making search requests
     by accepting keyword arguments directly instead of building URL strings.
     """
-    from urllib.parse import urlencode
-
     query_string = urlencode(params, doseq=True)
     return client.get(f"/search.json?{query_string}")
 

openlibrary/tests/fastapi/test_trending.py

@@ -1,9 +1,13 @@
 """Tests for the /trending/{period}.json FastAPI endpoint (internal API)."""
 
+from typing import get_args
 from unittest.mock import patch
 
 import pytest
 
+from openlibrary.fastapi.internal.api import TrendingPeriod
+from openlibrary.views.loanstats import SINCE_DAYS
+
 MOCK_WORKS = [
     {"key": "/works/OL1W", "title": "Popular Book 1", "author_name": ["Author A"]},
     {"key": "/works/OL2W", "title": "Popular Book 2", "author_name": ["Author B"]},
@@ -109,11 +113,6 @@ def test_limit_defaults_to_100(self, fastapi_client, mock_get_trending_books):
         assert mock_get_trending_books.call_args.kwargs["limit"] == 100
 
     def test_trending_period_literal_matches_since_days(self):
-        from typing import get_args
-
-        from openlibrary.fastapi.internal.api import TrendingPeriod
-        from openlibrary.views.loanstats import SINCE_DAYS
-
         literal_keys = set(get_args(TrendingPeriod))
         since_days_keys = set(SINCE_DAYS.keys())