Skip to content

Commit 117a4cb

Browse files
committed
fix: revert spacing tokens that cause visual regressions
- headings.css: restore 22px padding-left on .merge span to prevent text overlapping the 16px background icon - buttonCta.css: restore 1px margin-left on .cta-button-group items to preserve the connected button group appearance - edit-toolbar--tablet.css: replace primitive --spacing-3xs with semantic tokens Made-with: Cursor
1 parent 8313535 commit 117a4cb

4 files changed

Lines changed: 9 additions & 5 deletions

File tree

bundlesize.config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
},
6868
{
6969
"path": "static/build/css/page-book.css",
70-
"maxSize": "15.5KB"
70+
"maxSize": "15.7KB"
7171
},
7272
{
7373
"path": "static/build/css/page-edit.css",

static/css/base/headings.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@ h4.facetHead span.merge {
107107
font-size: var(--font-size-label-small);
108108
font-weight: normal !important;
109109
text-transform: none !important;
110-
padding-left: var(--spacing-inline-xl);
110+
/* Not tokenized: must exceed the 16px icon width to avoid text overlap */
111+
padding-left: 22px;
111112
background: url(/images/icons/icon_merge-sm.png) no-repeat 0 0;
112113
min-height: 16px;
113114
}

static/css/components/buttonCta.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,12 +272,14 @@ a.cta-btn__badge {
272272

273273
/* stylelint-disable-next-line selector-max-specificity */
274274
.cta-button-group > .cta-btn:not(:first-child):not(:last-child) {
275-
margin-left: var(--spacing-inline-xs);
275+
/* Not tokenized: 1px gap is intentional for connected button group appearance */
276+
margin-left: 1px;
276277
border-radius: 2px;
277278
}
278279

279280
/* stylelint-disable-next-line selector-max-specificity */
280281
.cta-button-group > .cta-btn:last-child:not(:first-child) {
281-
margin-left: var(--spacing-inline-xs);
282+
/* Not tokenized: 1px gap is intentional for connected button group appearance */
283+
margin-left: 1px;
282284
border-radius: 2px 6px 6px 2px;
283285
}

static/css/components/edit-toolbar--tablet.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
div#editTools,
33
div.editButton,
44
div#editHistory {
5-
padding: var(--spacing-3xs) var(--spacing-inset-xs) 0 var(--spacing-inset-sm);
5+
padding: var(--spacing-stack-xs) var(--spacing-inline-sm) 0
6+
var(--spacing-inline-md);
67
margin-top: -5px;
78
float: right;
89
}

0 commit comments

Comments
 (0)