Merge pull request #1267 from cdrini/refactor/node-20

Upgrade to Node 20

Author: cdrini

.github/workflows/node.js.yml

@@ -18,7 +18,7 @@ jobs:
     - uses: actions/setup-node@v4
       with:
         # Keep in sync with netlify.toml
-        node-version: 16.x
+        node-version: 20.x
     - name: Cache node_modules
       uses: actions/cache@v3
       id: cache
@@ -29,7 +29,7 @@ jobs:
         # we don't use `npm ci` specifically to try to get faster CI flows. So caching
         # `node_modules` directly.
         path: 'node_modules'
-        key: ${{ runner.os }}-node-16-${{ hashFiles('package*.json') }}
+        key: ${{ runner.os }}-node-20-${{ hashFiles('package*.json') }}
     - if: steps.cache.outputs.cache-hit != 'true'
       run: npm install
 
@@ -40,13 +40,13 @@ jobs:
     - uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
-        node-version: 16.x
+        node-version: 20.x
     - name: Load node_modules from cache
       uses: actions/cache@v3
       with:
         # Use node_modules from previous jobs
         path: 'node_modules'
-        key: ${{ runner.os }}-node-16-${{ hashFiles('package*.json') }}
+        key: ${{ runner.os }}-node-20-${{ hashFiles('package*.json') }}
     - name: Cache BookReader/
       uses: actions/cache@v3
       id: build-cache
@@ -64,13 +64,13 @@ jobs:
     - uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
-        node-version: 16.x
+        node-version: 20.x
     - name: Load node_modules from cache
       uses: actions/cache@v3
       with:
         # Use node_modules from previous jobs
         path: 'node_modules'
-        key: ${{ runner.os }}-node-16-${{ hashFiles('package*.json') }}
+        key: ${{ runner.os }}-node-20-${{ hashFiles('package*.json') }}
     - run: npm run lint
     - run: npm run test
     - run: npm run codecov
@@ -82,13 +82,13 @@ jobs:
     - uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
-        node-version: 16.x
+        node-version: 20.x
     - name: Load node_modules from cache
       uses: actions/cache@v3
       with:
         # Use node_modules from previous jobs
         path: 'node_modules'
-        key: ${{ runner.os }}-node-16-${{ hashFiles('package*.json') }}
+        key: ${{ runner.os }}-node-20-${{ hashFiles('package*.json') }}
     - name: Load BookReader/ from cache
       uses: actions/cache@v3
       with:

.github/workflows/npm-publish.yml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
       - run: npm ci
       - run: npm test
 
@@ -25,7 +25,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
           registry-url: https://registry.npmjs.org/
       - run: npm ci
       - run: npm publish --tag next

netlify.toml

@@ -1,6 +1,6 @@
 [build.environment]
   # Keep in sync with CI in .github/workflows/node.js.yml
-  NODE_VERSION = "16"
+  NODE_VERSION = "20"
 
 [[headers]]
   # Define which paths this specific [[headers]] block will cover.

package-lock.json

@@ -67,7 +67,6 @@
     "jquery-ui-touch-punch": "0.2.3",
     "jquery.browser": "0.1.0",
     "live-server": "1.2.2",
-    "node-fetch": "3.3.2",
     "regenerator-runtime": "0.13.11",
     "sass": "1.64.2",
     "sinon": "^17.0.0",

package.json

@@ -2,10 +2,6 @@ const { version: OLD_VERSION } = require('../package.json');
 const OLD_RELEASE_URL = `https://api.github.com/repos/internetarchive/bookreader/releases/tags/v${OLD_VERSION}`;
 
 async function main() {
-    // Need this because fetch is ESM-only, and we're on Node 16. Someday we should
-    // be able to move this up to the top without renaming this file to a .mjs or whatever
-    const {default: fetch} = await import('node-fetch');
-
     const {created_at} = await fetch(OLD_RELEASE_URL).then(r => r.json());
     const today = new Date().toISOString().slice(0, -5);
     const searchUrl = 'https://github.com/internetarchive/bookreader/pulls?' + new URLSearchParams({