improve overall performance & stability

Author: yuriy-glotanov

src/main/java/su/interference/core/AllowRPredicate.java

@@ -29,6 +29,6 @@ this software and associated documentation files (the "Software"), to deal in
  * @since 1.0
  */
 
-public interface AllowRPredicate {
+interface AllowRPredicate {
     boolean isAllowR();
 }

src/main/java/su/interference/core/ChunkIdComparator.java

@@ -39,6 +39,7 @@ public ChunkIdComparator(Session s) {
         this.s = s;
     }
 
+    @SuppressWarnings("unchecked")
     public int compare(Chunk c1, Chunk c2) {
         try {
             return c1.getId(null, s).compareTo(c2.getId(null, s));

src/main/java/su/interference/core/ChunkMap.java

@@ -47,6 +47,7 @@ public ChunkMap(Frame frame) {
         this.frame = frame;
     }
 
+    @SuppressWarnings("unchecked")
     public synchronized void sort() {
         Collections.sort(list);
         sorted = true;

src/main/java/su/interference/core/DataChunkId.java

@@ -62,6 +62,7 @@ private byte[] getBytes(Field f, Object o) throws IllegalAccessException, Unsupp
     }
 
     //serializer
+    @SuppressWarnings("unchecked")
     public DataChunkId (Object o, Session s) throws IOException, InvocationTargetException, NoSuchMethodException, InternalException, ClassNotFoundException, InstantiationException, IllegalAccessException {
         Class c = o.getClass();
         final SystemEntity sa = (SystemEntity)c.getAnnotation(SystemEntity.class);

src/main/java/su/interference/core/EntityFactory.java

@@ -71,6 +71,7 @@ public EntityFactory(Class<T> cl, Session s) {
         this.s = s;
     }
 
+    @SuppressWarnings("unchecked")
     public T get(Object[] params) {
         T o = null;
         try {

src/main/java/su/interference/core/Frame.java

@@ -360,11 +360,7 @@ public synchronized byte[] getFrame() throws InvalidFrame {
     }
 
     public boolean equals (Frame bl) {
-        if ((this.file==bl.getFile())&&(this.pointer==bl.getPointer())) {
-            return true;
-        } else {
-            return false;
-        }
+        return (this.file == bl.getFile()) && (this.pointer == bl.getPointer());
     }
 
     public int compareTo(Object obj) {
@@ -456,8 +452,7 @@ public synchronized int updateChunk(DataChunk chunk, Object o, Session s, LLT ll
         // chunk.getHeader().setState(Header.RECORD_UPDATED_STATE);
         chunk.getHeader().setLen(ncb.length);
         chunk.getHeader().setTran(tran);
-        final int newlen = chunk.getBytesAmount();
-        return newlen;
+        return chunk.getBytesAmount();
     }
 
     public synchronized void deleteChunk (int ptr, Session s, LLT llt) {
@@ -608,6 +603,7 @@ public synchronized void rollbackTransaction(Transaction tran, ArrayList<FrameDa
         llt.commit();
     }
 
+    @SuppressWarnings("unchecked")
     public HashMap getLiveTransactions() {
         final HashMap rtran = new HashMap<Long, Transaction>();
         for (Chunk c : data.getChunks()) {

src/main/java/su/interference/core/IndexElementKey.java

@@ -53,6 +53,7 @@ public IndexElementKey (int p1, long p2) {
         this.key[1] = p2;
     }
 
+    @SuppressWarnings("unchecked")
     public int compareTo(final Object obj) {
         final IndexElementKey j = (IndexElementKey)obj;
 
@@ -72,8 +73,7 @@ public int compareTo(final Object obj) {
 
     public boolean equals(final Object obj) {
         final IndexElementKey j = (IndexElementKey)obj;
-        if (this.compareTo(j) == 0) { return true; }
-        return false;
+        return this.compareTo(j) == 0;
     }
 
     public Object[] getKey() {

src/main/java/su/interference/core/IndexElementList.java

@@ -127,12 +127,10 @@ public IndexElement get(final int index) {
     }
 
     private boolean isFill() {
-        if (this.elementList.size()>=MAX_LIST_SIZE) {
-            return true;
-        }
-        return false;
+        return this.elementList.size() >= MAX_LIST_SIZE;
     }
 
+    @SuppressWarnings("unchecked")
     public synchronized IndexElementKey sort() {
         Collections.sort(this.elementList);
         this.sorted = true;

src/main/java/su/interference/core/IndexFrame.java

@@ -219,10 +219,7 @@ public DataChunk get (int index) {
     }
 
     private boolean isFill(DataChunk ie) {
-        if (ie.getBytesAmount()>this.getFrameFree()) {
-            return true;
-        }
-        return false;
+        return ie.getBytesAmount() > this.getFrameFree();
     }
 
     public ValueSet sort() throws InternalException {

src/main/java/su/interference/core/Instance.java

@@ -421,6 +421,7 @@ private static void registerMetrics() throws Exception {
         Metrics.register(Metrics.METER, "imUndoFrames");
     }
 
+    @SuppressWarnings("unchecked")
     private void checkInMemoryIndexes() {
         final MapField map = tt.getMapFieldByColumn("name");
         final Set<Map.Entry> xx = map.getMap().entrySet();
@@ -430,6 +431,7 @@ private void checkInMemoryIndexes() {
         }
     }
 
+    @SuppressWarnings("unchecked")
     private void startProcesses(Session s) throws Exception {
         final Table t = getTableByName("su.interference.persistent.Process");
         final List<Process> pss = Instance.getInstance().getProcesses();
@@ -704,8 +706,7 @@ public TransFrame getTransFrameById(long transId, long cframeId, long uframe) {
     @Deprecated
     public synchronized ArrayList<TransFrame> getTransFrameByObjectId (int objectId) {
         //final Table t = getTableByName("su.interference.persistent.TransFrame");
-        final ArrayList<TransFrame> r = new ArrayList<TransFrame>();
-        return r;
+        return new ArrayList<TransFrame>();
     }
 
     public RetrieveLock getRetrieveLockById(RetrieveLock p) {