test: Added unit test for Port_util

Author: AndreasAakesson

api/net/port_util.hpp

@@ -129,8 +129,7 @@ class Port_util {
     // while(is_bound(ephemeral_)) ++ephemeral_; // worst case is like 16k iterations :D
     // need a solution that checks each word of the subset (the dynamic range)
     // FIXME: this may happen...
-    if(UNLIKELY( is_bound(ephemeral_) ))
-      throw Port_error{"Generated ephemeral port is already bound. Please fix me!"};
+    Expects(not is_bound(ephemeral_) && "Generated ephemeral port is already bound. Please fix me!");
   }
 }; // < class Port_util
 

test/CMakeLists.txt

@@ -85,6 +85,7 @@ set(TEST_SOURCES
   ${TEST}/net/unit/ip4_addr.cpp
   ${TEST}/net/unit/ip4.cpp
   ${TEST}/net/unit/packets.cpp
+  ${TEST}/net/unit/port_util_test.cpp
   ${TEST}/net/unit/socket.cpp
   ${TEST}/net/unit/tcp_packet_test.cpp
   ${TEST}/net/unit/tcp_write_queue.cpp

test/net/unit/port_util_test.cpp

@@ -0,0 +1,65 @@
+// This file is a part of the IncludeOS unikernel - www.includeos.org
+//
+// Copyright 2017 Oslo and Akershus University College of Applied Sciences
+// and Alfred Bratterud
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include <common.cxx>
+#include <net/port_util.hpp>
+
+CASE("Binding and unbinding")
+{
+  net::Port_util util;
+
+  const uint16_t port = 322;
+
+  EXPECT(util.is_bound(port) == false);
+
+  util.bind(port);
+
+  EXPECT(util.is_bound(port) == true);
+
+  util.unbind(port);
+
+  EXPECT(util.is_bound(port) == false);
+}
+
+CASE("Generating ephemeral port throws when all are bound")
+{
+  net::Port_util util;
+
+  // Bind all
+  for(auto i = 0; i < (net::port_ranges::DYNAMIC_END - net::port_ranges::DYNAMIC_START); ++i)
+    util.bind(util.get_next_ephemeral());
+
+  EXPECT_THROWS_AS(util.get_next_ephemeral(), net::Port_error);
+}
+
+CASE("[.expectedfailure] Generating ephemeral handles wrap around")
+{
+  net::Port_util util;
+
+  auto port = util.get_next_ephemeral();
+
+  // bind first one
+  util.bind(port);
+
+  // wrap around
+  for(auto i = 0; i < (net::port_ranges::DYNAMIC_END - net::port_ranges::DYNAMIC_START - 1); ++i)
+    util.get_next_ephemeral();
+
+  auto port2 = util.get_next_ephemeral();
+
+  EXPECT(port != port2);
+}