tcp: Don't skip holes in datastream

fwsGonzo · fwsGonzo · commit 9b49adf81432 · 2017-05-23T18:15:04.000+02:00
diff --git a/src/net/tcp/connection_states.cpp b/src/net/tcp/connection_states.cpp
@@ -123,8 +123,11 @@ bool Connection::State::check_seq(Connection& tcp, const Packet& in)
   if( in.seq() == tcb.RCV.NXT ) {
     goto acceptable;
   }
+  /// TODO: FIXME: reordering issues solved by this
+  else goto unacceptable;
+
   // #2
-  else if( tcb.RCV.NXT <= in.seq() and in.seq() < tcb.RCV.NXT + tcb.RCV.WND ) {
+  if( tcb.RCV.NXT <= in.seq() and in.seq() < tcb.RCV.NXT + tcb.RCV.WND ) {
     goto acceptable;
   }
   // #3 (INVALID)

Original file line number	Diff line number	Diff line change
`@@ -123,8 +123,11 @@ bool Connection::State::check_seq(Connection& tcp, const Packet& in)`
`123`	`123`	`if( in.seq() == tcb.RCV.NXT ) {`
`124`	`124`	`goto acceptable;`
`125`	`125`	`}`
	`126`	`+ /// TODO: FIXME: reordering issues solved by this`
	`127`	`+ else goto unacceptable;`
	`128`	`+`
`126`	`129`	`// #2`
`127`		`- else if( tcb.RCV.NXT <= in.seq() and in.seq() < tcb.RCV.NXT + tcb.RCV.WND ) {`
	`130`	`+ if( tcb.RCV.NXT <= in.seq() and in.seq() < tcb.RCV.NXT + tcb.RCV.WND ) {`
`128`	`131`	`goto acceptable;`
`129`	`132`	`}`
`130`	`133`	`// #3 (INVALID)`