Skip to content

Commit 25d5a99

Browse files
committed
revert url_for magic for generating links in email template
1 parent 26432a4 commit 25d5a99

2 files changed

Lines changed: 5 additions & 8 deletions

File tree

users/templates/text/registration_confirmation_email.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ to the centre of your nearest town / state or province or country).
1717

1818
Deleting or editing your user record does not require a user name or password, only that
1919
you click on this unique (for your user record) link below:
20-
- Link: {{ edit_url }}
20+
- Link: {{ url }}/edit/{{ user.guid }}
2121

2222
If you have ever forget your special link above, you can request this message to be
2323
resent to you by using the 'I forgot my edit link' menu on {{ url }}.

users/views.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"""
66
import json
77

8-
from flask import render_template, Response, request, url_for
8+
from flask import render_template, Response, request
99
from werkzeug.exceptions import default_exceptions
1010

1111
# App declared directly in __init__ as per
@@ -153,9 +153,7 @@ def add_user_view():
153153
body = render_template(
154154
'text/registration_confirmation_email.txt',
155155
project_name=APP.config['PROJECT_NAME'],
156-
url=url_for(".map_view", _external=True),
157-
edit_url=url_for(".edit_user_view", guid=added_user["guid"],
158-
_external=True),
156+
url=APP.config["PUBLIC_URL"],
159157
user=added_user)
160158
recipient = added_user['email']
161159
send_async_mail(
@@ -309,7 +307,7 @@ def delete_user_view(guid):
309307
"""
310308
# Delete User
311309
delete_user(guid)
312-
return url_for(".map_view")
310+
return APP.config["PUBLIC_URL"]
313311

314312

315313
@APP.route('/download')
@@ -364,8 +362,7 @@ def reminder_view():
364362
body = render_template(
365363
'text/registration_confirmation_email.txt',
366364
project_name=APP.config['PROJECT_NAME'],
367-
url=url_for(".map_view", _external=True),
368-
edit_url=url_for(".edit_user_view", guid=user["guid"], _external=True),
365+
url=APP.config["PUBLIC_URL"],
369366
user=user)
370367
send_async_mail(
371368
sender=MAIL_ADMIN,

0 commit comments

Comments
 (0)