Skip to content

Commit 94ac247

Browse files
committed
Disable warning when setting MInimumVersion ≥ 2
1 parent 9400ec9 commit 94ac247

2 files changed

Lines changed: 14 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/).
44

55

6+
## [1.8.1] - TBD
7+
8+
### Removed
9+
- Removed warning about setting MinimumVersion of AutoPkg recipes to 2.0+.
10+
11+
612
## [1.8.0] - 2020-10-08
713

814
### Changed

pre_commit_hooks/check_autopkg_recipes.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,14 @@ def validate_minimumversion(process, min_vers, ignore_min_vers_before, filename)
152152
"""Ensure MinimumVersion is set appropriately for the processors used."""
153153

154154
# Warn if using a MinimumVersion greater than or equal to 2
155-
if LooseVersion(min_vers) >= LooseVersion("2"):
156-
print(
157-
"{}: WARNING: Choosing MinimumVersion {} limits the potential "
158-
"audience for your AutoPkg recipe. Consider using MinimumVersion "
159-
"1.4.1 if your processors support it.".format(filename, min_vers)
160-
)
155+
# warn_on_vers = "2"
156+
# suggest_vers = "1.4.1"
157+
# if LooseVersion(min_vers) >= LooseVersion(warn_on_vers):
158+
# print(
159+
# "{}: WARNING: Choosing MinimumVersion {} limits the potential "
160+
# "audience for your AutoPkg recipe. Consider using MinimumVersion "
161+
# "{} if your processors support it.".format(filename, min_vers, suggest_vers)
162+
# )
161163

162164
# Processors for which a minimum version of AutoPkg is required.
163165
# Note: Because LooseVersion considers version 1.0 to be "less than" 1.0.0,

0 commit comments

Comments
 (0)