Detect incorrect pkginfo key "condition"

Author: homebysix

CHANGELOG.md

@@ -12,7 +12,9 @@ All notable changes to this project will be documented in this file. This projec
 
 ## [Unreleased]
 
-Nothing yet.
+### Added
+
+- `check-munki-pkgsinfo` now detects the incorrect key `condition` and suggests using `installable_condition` instead.
 
 ## [1.20.0] - 2025-08-09
 

pre_commit_hooks/util.py

@@ -102,6 +102,7 @@ def detect_typoed_keys(input_dict: Dict[str, Any], filename: str) -> bool:
         "blocking_apps": "blocking_applications",
         "blockingapplications": "blocking_applications",
         "choices_xml": "installer_choices_xml",
+        "condition": "installable_condition",
         "icon": "icon_name",
         "install_check_script": "installcheck_script",
         "installer_choices": "installer_choices_xml",

tests/test_util.py

@@ -106,6 +106,8 @@ def test_detect_deprecated_keys(self):
     def test_detect_typoed_keys(self):
         d = {"blocking_apps": 1}
         self.assertFalse(detect_typoed_keys(d, "file"))
+        d = {"condition": "some_condition"}
+        self.assertFalse(detect_typoed_keys(d, "file"))
         d = {"foo": 1}
         self.assertTrue(detect_typoed_keys(d, "file"))