open() defaults to "r"

Author: homebysix

pre_commit_hooks/check_autopkg_recipe_list.py

@@ -36,7 +36,7 @@ def main(argv=None):
     for filename in args.filenames:
         recipe_list = None
         if filename.endswith(".txt"):
-            with open(filename, "r", encoding="utf-8") as openfile:
+            with open(filename, encoding="utf-8") as openfile:
                 recipe_list = [
                     line
                     for line in openfile.read().splitlines()
@@ -53,7 +53,7 @@ def main(argv=None):
             # AutoPkg does not support YAML recipe lists, but AutoPkg users
             # may have developed custom tooling for this.
             try:
-                with open(filename, "r", encoding="utf-8") as openfile:
+                with open(filename, encoding="utf-8") as openfile:
                     recipe_list = yaml.load(openfile)
             except Exception as err:
                 print(f"{filename}: yaml parsing error: {err}")
@@ -62,7 +62,7 @@ def main(argv=None):
             # AutoPkg does not support JSON recipe lists, but AutoPkg users
             # may have developed custom tooling for this.
             try:
-                with open(filename, "r", encoding="utf-8") as openfile:
+                with open(filename, encoding="utf-8") as openfile:
                     recipe_list = json.load(openfile)
             except Exception as err:
                 print(f"{filename}: json parsing error: {err}")

pre_commit_hooks/check_autopkg_recipes.py

@@ -99,7 +99,7 @@ def validate_comments(filename, strict):
     plutil -convert xml1."""
 
     passed = True
-    with open(filename, "r", encoding="utf-8") as openfile:
+    with open(filename, encoding="utf-8") as openfile:
         recipe_text = openfile.read()
         if "<!--" in recipe_text and "-->" in recipe_text:
             if strict:

pre_commit_hooks/check_jamf_extension_attributes.py

@@ -32,7 +32,7 @@ def main(argv=None):
 
     retval = 0
     for filename in args.filenames:
-        with open(filename, "r", encoding="utf-8") as openfile:
+        with open(filename, encoding="utf-8") as openfile:
             ea_content = openfile.read()
 
         # Ensure script contains both <result> and </result> tags

pre_commit_hooks/check_jamf_scripts.py

@@ -31,7 +31,7 @@ def main(argv=None):
 
     retval = 0
     for filename in args.filenames:
-        with open(filename, "r", encoding="utf-8") as openfile:
+        with open(filename, encoding="utf-8") as openfile:
             script_content = openfile.read()
 
         # Ensure script starts with a shebang of some sort.

pre_commit_hooks/check_munkiadmin_scripts.py

@@ -33,7 +33,7 @@ def main(argv=None):
             retval = 1
 
         # Ensure scripts have a proper shebang
-        with open(filename, "r", encoding="utf-8") as openfile:
+        with open(filename, encoding="utf-8") as openfile:
             script_content = openfile.read()
         if not validate_shebangs(script_content, filename):
             print(f"{filename}: does not start with a valid shebang")

pre_commit_hooks/check_munkipkg_buildinfo.py

@@ -85,15 +85,15 @@ def main(argv=None):
                 break  # no need to continue testing this file
         elif filename.endswith((".yaml", ".yml")):
             try:
-                with open(filename, "r", encoding="utf-8") as openfile:
+                with open(filename, encoding="utf-8") as openfile:
                     buildinfo = yaml.load(openfile)
             except Exception as err:
                 print(f"{filename}: yaml parsing error: {err}")
                 retval = 1
                 break  # no need to continue testing this file
         elif filename.endswith(".json"):
             try:
-                with open(filename, "r", encoding="utf-8") as openfile:
+                with open(filename, encoding="utf-8") as openfile:
                     buildinfo = json.load(openfile)
             except Exception as err:
                 print(f"{filename}: json parsing error: {err}")

pre_commit_hooks/check_outset_scripts.py

@@ -31,7 +31,7 @@ def main(argv=None):
             retval = 1
 
         # Ensure scripts have a proper shebang
-        with open(filename, "r", encoding="utf-8") as openfile:
+        with open(filename, encoding="utf-8") as openfile:
             script_content = openfile.read()
         if not validate_shebangs(script_content, filename):
             print(f"{filename}: does not start with a valid shebang")