Detect missing uninstall_script

Author: homebysix

CHANGELOG.md

@@ -12,7 +12,9 @@ All notable changes to this project will be documented in this file. This projec
 
 ## [Unreleased]
 
-Nothing yet.
+### Added
+
+- `check-munki-pkgsinfo` now produces an error if `uninstall_method` is set to `uninstall_script` but no uninstall script is present in the pkginfo.
 
 ## [1.17.0] - 2024-12-22
 

pre_commit_hooks/check_munki_pkgsinfo.py

@@ -202,12 +202,19 @@ def main(argv=None):
                 retval = 1
 
         # Ensure uninstall method is set correctly if uninstall_script exists.
-        if "uninstall_script" in pkginfo:
-            if pkginfo.get("uninstall_method") != "uninstall_script":
-                print(
-                    f'{filename}: has uninstall script, but the uninstall method is set to "{pkginfo.get("uninstall_method")}"'
-                )
-                retval = 1
+        uninst_method = pkginfo.get("uninstall_method")
+        if "uninstall_script" in pkginfo and uninst_method != "uninstall_script":
+            print(
+                f"{filename}: has an uninstall script, but the uninstall "
+                f'method is set to "{uninst_method}"'
+            )
+            retval = 1
+        elif "uninstall_script" not in pkginfo and uninst_method == "uninstall_script":
+            print(
+                f"{filename}: uninstall_method is set to uninstall_script, "
+                'but no uninstall script is present"'
+            )
+            retval = 1
 
         # Ensure all pkginfo scripts have a proper shebang.
         script_types = (