Add --require-pkg-blocking-apps option for pkginfo checking

Author: homebysix

CHANGELOG.md

@@ -15,6 +15,7 @@ All notable changes to this project will be documented in this file. This projec
 ### Added
 
 - Added compatibility checks for MunkiOptionalReceiptEditor processor, included in AutoPkg 2.7+.
+- Added a `--require-pkg-blocking-apps` argument for the `check-munki-pkgsinfo` hook. If specified, tests will fail for any pkg installer that does not have a `blocking_applications` array (even an empty one). This change maintains the alignment with Munki's design established in 1.12.3 while allowing Munki repo admins flexibility to be stricter in their own environments.
 
 ### Changed
 

pre_commit_hooks/check_munki_pkgsinfo.py

@@ -28,6 +28,11 @@ def build_argument_parser():
         default=["description", "name"],
         help="List of required top-level keys.",
     )
+    parser.add_argument(
+        "--require-pkg-blocking-apps",
+        action="store_true",
+        help="Require a blocking_applications array for pkg installers.",
+    )
     parser.add_argument("filenames", nargs="*", help="Filenames to check.")
     return parser
 
@@ -120,7 +125,7 @@ def main(argv=None):
 
         # Checking for the absence of blocking_applications for pkg installers.
         # If a pkg doesn't require blocking_applications, use empty "<array/>" in pkginfo.
-        if all(
+        if args.require_pkg_blocking_apps and all(
             (
                 "blocking_applications" not in pkginfo,
                 pkginfo.get("installer_item_location", "").endswith(".pkg"),
@@ -129,10 +134,11 @@ def main(argv=None):
             )
         ):
             print(
-                "WARNING: {}: contains a pkg installer but has no blocking applications".format(
+                "{}: contains a pkg installer but missing a blocking applications array".format(
                     filename
                 )
             )
+            retval = 1
 
         # Ensure an icon exists for the item.
         if not any(