Skip to content

Commit 4f7562f

Browse files
committed
Fail checks if required strings are empty
1 parent 485a0ca commit 4f7562f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

pre_commit_hooks/check_preference_manifests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def validate_required_keys(input_dict, required_keys, dict_name, filename):
4343
"""Verifies that required_keys are present in dictionary."""
4444
passed = True
4545
for req_key in required_keys:
46-
if not input_dict.get(req_key):
46+
if input_dict.get(req_key, "") == "":
4747
print("{}: {} missing required key {}".format(filename, dict_name, req_key))
4848
passed = False
4949
return passed

0 commit comments

Comments
 (0)