Validate Munki supported_architectures values

Author: homebysix

CHANGELOG.md

@@ -16,6 +16,7 @@ All notable changes to this project will be documented in this file. This projec
 
 - `check-autopkg-recipes` requires Munki recipe `pkginfo` dicts to contain at least `name` and `description`.
 - `check-autopkg-recipes` now validates that `uninstall_method` and `uninstall_script` are set appropriately in Munki recipes.
+- `check-autopkg-recipes` and `check-munki-pkgsinfo` now validates that `supported_architectures` values are set appropriately.
 
 ### Changed
 

pre_commit_hooks/check_autopkg_recipes.py

@@ -16,6 +16,7 @@
     validate_pkginfo_key_types,
     validate_required_keys,
     validate_restart_action_key,
+    validate_supported_architectures,
     validate_uninstall_method,
 )
 
@@ -636,6 +637,10 @@ def main(argv=None):
             if not validate_uninstall_method(input_key["pkginfo"], filename):
                 retval = 1
 
+            # Validate supported architectures.
+            if not validate_supported_architectures(input_key["pkginfo"], filename):
+                retval = 1
+
             # Check for deprecated pkginfo keys.
             if not detect_deprecated_keys(input_key["pkginfo"], filename):
                 retval = 1

pre_commit_hooks/check_munki_pkgsinfo.py

@@ -14,6 +14,7 @@
     validate_required_keys,
     validate_restart_action_key,
     validate_shebangs,
+    validate_supported_architectures,
     validate_uninstall_method,
 )
 
@@ -122,6 +123,10 @@ def main(argv=None):
         if not validate_uninstall_method(pkginfo, filename):
             retval = 1
 
+        # Validate supported architectures.
+        if not validate_supported_architectures(pkginfo, filename):
+            retval = 1
+
         # Check for deprecated pkginfo keys.
         if not detect_deprecated_keys(pkginfo, filename):
             retval = 1

pre_commit_hooks/util.py

@@ -178,6 +178,20 @@ def validate_uninstall_method(pkginfo, filename):
     return passed
 
 
+def validate_supported_architectures(pkginfo, filename):
+    """Verifies that supported_architectures values are valid."""
+    passed = True
+    allowed_values = ("arm64", "x86_64")
+    if "supported_architectures" in pkginfo:
+        for arch in pkginfo["supported_architectures"]:
+            if arch not in allowed_values:
+                print(
+                    f"{filename}: supported_architectures contains unexpected value: {arch}"
+                )
+                passed = False
+    return passed
+
+
 def validate_pkginfo_key_types(pkginfo, filename):
     """Validation of pkginfo key types.