Fix coverity warning

hoene · hoene · commit 8dda834bf985 · 2021-01-24T18:20:42.000+01:00
diff --git a/src/hdf/dataobject.c b/src/hdf/dataobject.c
@@ -67,11 +67,11 @@ static int readOHDRHeaderMessageDataspace1(struct READER *reader,
     if (i < 4) {
       ds->dimension_size[i] =
           readValue(reader, reader->superblock.size_of_lengths);
-      mylog("   dimension %d %" PRIu64 "\n", i, ds->dimension_size[i]);
-      if (ds->dimension_size[i] > 1000000) {
+      if (ds->dimension_size[i] < 0 || ds->dimension_size[i] > 1000000) {
         mylog("dimension_size is too large\n"); // LCOV_EXCL_LINE
         return MYSOFA_INVALID_FORMAT;           // LCOV_EXCL_LINE
       }
+      mylog("   dimension %d %" PRIu64 "\n", i, ds->dimension_size[i]);
     } else
       readValue(reader, reader->superblock.size_of_lengths);
   }

Original file line number	Diff line number	Diff line change
`@@ -67,11 +67,11 @@ static int readOHDRHeaderMessageDataspace1(struct READER *reader,`
`67`	`67`	`if (i < 4) {`
`68`	`68`	`ds->dimension_size[i] =`
`69`	`69`	`readValue(reader, reader->superblock.size_of_lengths);`
`70`		`- mylog(" dimension %d %" PRIu64 "\n", i, ds->dimension_size[i]);`
`71`		`- if (ds->dimension_size[i] > 1000000) {`
	`70`	`+ if (ds->dimension_size[i] < 0 \|\| ds->dimension_size[i] > 1000000) {`
`72`	`71`	`mylog("dimension_size is too large\n"); // LCOV_EXCL_LINE`
`73`	`72`	`return MYSOFA_INVALID_FORMAT; // LCOV_EXCL_LINE`
`74`	`73`	`}`
	`74`	`+ mylog(" dimension %d %" PRIu64 "\n", i, ds->dimension_size[i]);`
`75`	`75`	`} else`
`76`	`76`	`readValue(reader, reader->superblock.size_of_lengths);`
`77`	`77`	`}`