Fixed four coverity issues

Author: hoene

src/hdf/dataobject.c

@@ -521,7 +521,7 @@ static int readOHDRHeaderMessageDataLayout(struct READER *reader,
       if (fseek(reader->fhd, data_address, SEEK_SET) < 0)
         return errno;
       if (!data->data) {
-        if (size < 0 || size > 0x10000000)
+        if (size > 0x10000000)
           return MYSOFA_INVALID_FORMAT;
         data->data_len = size;
         data->data = calloc(1, size);
@@ -862,20 +862,25 @@ static int readOHDRHeaderMessageAttribute(struct READER *reader,
     free(name);
     return MYSOFA_INVALID_FORMAT;
   }
-  if (version == 1)
-    if (fseek(reader->fhd, (8 - datatype_size) & 7, SEEK_CUR) < 0)
+  if (version == 1) {
+    if (fseek(reader->fhd, (8 - datatype_size) & 7, SEEK_CUR) < 0) {
+      free(name);
       return errno;
+    }
+  }
 
   err = readOHDRHeaderMessageDataspace(reader, &d.ds);
   if (err) {
     mylog("object OHDR attribute message read dataspace error\n");
     free(name);
     return MYSOFA_INVALID_FORMAT;
   }
-  if (version == 1)
-    if (fseek(reader->fhd, (8 - dataspace_size) & 7, SEEK_CUR) < 0)
+  if (version == 1) {
+    if (fseek(reader->fhd, (8 - dataspace_size) & 7, SEEK_CUR) < 0) {
+      free(name);
       return errno;
-
+    }
+  }
   err = readData(reader, &d, &d.dt, &d.ds);
   if (err) {
     mylog("object OHDR attribute message read data error\n");

src/tests/multithread.c

@@ -92,8 +92,9 @@ void *thread(void *arg) {
       sdiff2 = sdiff2 / (count - err);
     }
 #ifdef VDEBUG
-    printf("errors %f%% diffs %f %f\n", err * 100. / count,
-           sdiff1 / (count - err), sdiff2 / (count - err));
+    if (count != 0 && count != err)
+      printf("errors %f%% diffs %f %f\n", err * 100. / count,
+             sdiff1 / (count - err), sdiff2 / (count - err));
 #endif
     if (!(err < 31.7 && sdiff1 < 1.67 && sdiff2 < 1.43)) {
       abort();