Merge pull request jruby#9240 from evaniainbrooks/9120-incompat-encoding

Fix for File.path doesn't raise Encoding::CompatibilityError for ASCII incompatible string

Author: enebo

core/src/main/java/org/jruby/RubyFile.java

@@ -1365,7 +1365,7 @@ public static String getAdjustedPath(ThreadContext context, IRubyObject fileOrPa
 
     // mri: FilePathValue/rb_get_path/rb_get_patch_check
     public static RubyString get_path(ThreadContext context, IRubyObject path) {
-        if (path instanceof RubyString) return checkEmbeddedNulls(context, path);
+        if (path instanceof RubyString) return filePathConvert(context, (RubyString) path);
 
         FileSites sites = sites(context);
         if (sites.respond_to_to_path.respondsTo(context, path, path, true)) path = sites.to_path.call(context, path, path);
@@ -1378,6 +1378,10 @@ public static RubyString get_path(ThreadContext context, IRubyObject path) {
     protected static RubyString filePathConvert(ThreadContext context, RubyString path) {
         checkEmbeddedNulls(context, path);
 
+        if (!path.getEncoding().isAsciiCompatible()) {
+            throw context.runtime.newEncodingCompatibilityError("path name must be ASCII-compatible (" + path.getEncoding() + "): " + path);
+        }
+
         if (!Platform.IS_WINDOWS) {
             var encodingService = encodingService(context);
             Encoding pathEncoding = path.getEncoding();

spec/tags/ruby/core/file/path_tags.txt

@@ -1,3 +1 @@
 fails:File#path preserves the encoding of the path
-fails:File.path raises Encoding::CompatibilityError for ASCII-incompatible string argument
-fails:File.path raises Encoding::CompatibilityError when #to_path result is ASCII-incompatible