Skip to content

Commit 140c56c

Browse files
authored
Don't reexport Data.Word (#225)
1 parent 245f989 commit 140c56c

7 files changed

Lines changed: 13 additions & 9 deletions

File tree

benchmarks/Benchmark.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import qualified Data.ByteString.Lazy as L
55
import Data.Binary
66
import Data.Binary.Put
77
import Data.Binary.Get
8+
import Data.Word
89

910
import Control.Exception
1011
import System.CPUTime

benchmarks/Get.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import qualified Data.ByteString.Lazy as L
77
import Data.Bits
88
import Data.Char (ord)
99
import Data.List (foldl')
10+
import Data.Word
1011
import Test.Tasty.Bench
1112

1213
import Control.Applicative

benchmarks/Put.hs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,14 @@ import Control.Exception (evaluate)
55
import qualified Data.ByteString as S
66
import qualified Data.ByteString.Char8 as C
77
import qualified Data.ByteString.Lazy as L
8-
import Data.Monoid
8+
import Data.Word
99
import Test.Tasty.Bench
1010

1111
import GHC.Generics
1212

1313
import Data.Binary
1414
import Data.Binary.Put
1515
import Data.ByteString.Builder as BB
16-
import Prelude -- Silence Monoid import warning.
1716

1817
main :: IO ()
1918
main = do

changelog.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
binary
22
======
33

4+
binary-0.9.0.0
5+
--------------
6+
7+
- Don't reexport `Data.Word` from `Data.Binary`
8+
49
binary-0.8.9.2
510
--------------
611

@@ -170,7 +175,7 @@ binary-0.7.1.0
170175
--------------
171176

172177
- Add `lookAheadE :: Get (Either a b) -> Get (Either a b)`.
173-
- Add MonadPlus instance for Get.
178+
- Add MonadPlus instance for Get.
174179

175180

176181
binary-0.7.0.1

src/Data/Binary.hs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,8 @@ module Data.Binary (
6767
, decodeFile -- :: Binary a => FilePath -> IO a
6868
, decodeFileOrFail
6969

70-
, module Data.Word -- useful
71-
7270
) where
7371

74-
import Data.Word
75-
7672
import Data.Binary.Class
7773
import Data.Binary.Put
7874
import Data.Binary.Get

tests/File.hs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import Distribution.Simple.Utils (withTempDirectory)
1313
import Distribution.Verbosity (silent)
1414

1515
import Data.Binary
16+
import Data.Word
1617

1718
data Foo = Bar !Word32 !Word32 !Word32 deriving (Eq, Show)
1819

@@ -38,6 +39,6 @@ readWriteTest = TestCase $ do
3839
exampleData @=? content
3940

4041
main :: IO ()
41-
main = do
42+
main = do
4243
_ <- runTestTT readWriteTest
43-
return ()
44+
return ()

tests/QC.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import Data.ByteString.Short (ShortByteString)
2222
import Data.Int
2323
import Data.Ratio
2424
import Data.Typeable
25+
import Data.Word
2526
import System.IO.Unsafe
2627

2728
import Data.Orphans ()

0 commit comments

Comments
 (0)