Skip to content

Commit 4c2a6f1

Browse files
kubeclaude
andcommitted
FE-518: Fix PR review findings for refractive
- Bump Storybook from 10.2.13 to 10.2.19 for Vite 8 compatibility - Update ds-components/switch.tsx to use renamed `lip` export Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent f34deb3 commit 4c2a6f1

3 files changed

Lines changed: 6 additions & 122 deletions

File tree

libs/@hashintel/ds-components/src/components/switch.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Switch as BaseSwitch } from "@ark-ui/react/switch";
22
import { css } from "@hashintel/ds-helpers/css";
3-
import { LIP, refractive } from "@hashintel/refractive";
3+
import { lip, refractive } from "@hashintel/refractive";
44

55
// Layout constants
66
const SLIDER_HEIGHT = 20;
@@ -104,7 +104,7 @@ export const Switch: React.FC<SwitchProps> = ({
104104
refraction={{
105105
radius: THUMB_RADIUS,
106106
bezelWidth: THUMB_RADIUS * 0.42,
107-
bezelHeightFn: LIP,
107+
bezelHeightFn: lip,
108108
glassThickness: 12,
109109
specularOpacity: 0.5,
110110
}}

libs/@hashintel/refractive/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
},
3333
"devDependencies": {
3434
"@rolldown/plugin-babel": "0.2.1",
35-
"@storybook/react-vite": "10.2.13",
35+
"@storybook/react-vite": "10.2.19",
3636
"@types/react": "19.2.7",
3737
"@types/react-dom": "19.2.3",
3838
"@typescript/native-preview": "7.0.0-dev.20260315.1",
@@ -41,7 +41,7 @@
4141
"oxlint": "1.55.0",
4242
"oxlint-tsgolint": "0.17.0",
4343
"rolldown-plugin-dts": "0.22.5",
44-
"storybook": "10.2.13",
44+
"storybook": "10.2.19",
4545
"vite": "8.0.0"
4646
},
4747
"peerDependencies": {

yarn.lock

Lines changed: 2 additions & 118 deletions
Original file line numberDiff line numberDiff line change
@@ -8023,7 +8023,7 @@ __metadata:
80238023
resolution: "@hashintel/refractive@workspace:libs/@hashintel/refractive"
80248024
dependencies:
80258025
"@rolldown/plugin-babel": "npm:0.2.1"
8026-
"@storybook/react-vite": "npm:10.2.13"
8026+
"@storybook/react-vite": "npm:10.2.19"
80278027
"@types/react": "npm:19.2.7"
80288028
"@types/react-dom": "npm:19.2.3"
80298029
"@typescript/native-preview": "npm:7.0.0-dev.20260315.1"
@@ -8032,7 +8032,7 @@ __metadata:
80328032
oxlint: "npm:1.55.0"
80338033
oxlint-tsgolint: "npm:0.17.0"
80348034
rolldown-plugin-dts: "npm:0.22.5"
8035-
storybook: "npm:10.2.13"
8035+
storybook: "npm:10.2.19"
80368036
vite: "npm:8.0.0"
80378037
peerDependencies:
80388038
react: ^19.0.0
@@ -16930,19 +16930,6 @@ __metadata:
1693016930
languageName: node
1693116931
linkType: hard
1693216932

16933-
"@storybook/builder-vite@npm:10.2.13":
16934-
version: 10.2.13
16935-
resolution: "@storybook/builder-vite@npm:10.2.13"
16936-
dependencies:
16937-
"@storybook/csf-plugin": "npm:10.2.13"
16938-
ts-dedent: "npm:^2.0.0"
16939-
peerDependencies:
16940-
storybook: ^10.2.13
16941-
vite: ^5.0.0 || ^6.0.0 || ^7.0.0
16942-
checksum: 10c0/0510e57d86ea7f81ba49ffd3643645e94e082f18544bd506bdcd800c003414707d3572c204704dfe429a3e02fa1bdf6111d309abbd20a294200cb9ba87ea7972
16943-
languageName: node
16944-
linkType: hard
16945-
1694616933
"@storybook/builder-vite@npm:10.2.19":
1694716934
version: 10.2.19
1694816935
resolution: "@storybook/builder-vite@npm:10.2.19"
@@ -16969,30 +16956,6 @@ __metadata:
1696916956
languageName: node
1697016957
linkType: hard
1697116958

16972-
"@storybook/csf-plugin@npm:10.2.13":
16973-
version: 10.2.13
16974-
resolution: "@storybook/csf-plugin@npm:10.2.13"
16975-
dependencies:
16976-
unplugin: "npm:^2.3.5"
16977-
peerDependencies:
16978-
esbuild: "*"
16979-
rollup: "*"
16980-
storybook: ^10.2.13
16981-
vite: "*"
16982-
webpack: "*"
16983-
peerDependenciesMeta:
16984-
esbuild:
16985-
optional: true
16986-
rollup:
16987-
optional: true
16988-
vite:
16989-
optional: true
16990-
webpack:
16991-
optional: true
16992-
checksum: 10c0/e799f9630cfc50ef3c85304f74ffb54372e57f291112d7459de99f4fa21da814374807ac6af312141af11f5e0c746963735e1e41566dd62d0ac7eeb8cf0053ba
16993-
languageName: node
16994-
linkType: hard
16995-
1699616959
"@storybook/csf-plugin@npm:10.2.19":
1699716960
version: 10.2.19
1699816961
resolution: "@storybook/csf-plugin@npm:10.2.19"
@@ -17064,17 +17027,6 @@ __metadata:
1706417027
languageName: node
1706517028
linkType: hard
1706617029

17067-
"@storybook/react-dom-shim@npm:10.2.13":
17068-
version: 10.2.13
17069-
resolution: "@storybook/react-dom-shim@npm:10.2.13"
17070-
peerDependencies:
17071-
react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17072-
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17073-
storybook: ^10.2.13
17074-
checksum: 10c0/78c9788748aae81541727e3cfe32dc1c14aef10af0a5c979d307ec1910d15d5105341ce1c2d5d27ae9ad40dec6de6c0c9c85dfbf12f90c14da678eee5581a3cf
17075-
languageName: node
17076-
linkType: hard
17077-
1707817030
"@storybook/react-dom-shim@npm:10.2.19":
1707917031
version: 10.2.19
1708017032
resolution: "@storybook/react-dom-shim@npm:10.2.19"
@@ -17097,28 +17049,6 @@ __metadata:
1709717049
languageName: node
1709817050
linkType: hard
1709917051

17100-
"@storybook/react-vite@npm:10.2.13":
17101-
version: 10.2.13
17102-
resolution: "@storybook/react-vite@npm:10.2.13"
17103-
dependencies:
17104-
"@joshwooding/vite-plugin-react-docgen-typescript": "npm:^0.6.4"
17105-
"@rollup/pluginutils": "npm:^5.0.2"
17106-
"@storybook/builder-vite": "npm:10.2.13"
17107-
"@storybook/react": "npm:10.2.13"
17108-
empathic: "npm:^2.0.0"
17109-
magic-string: "npm:^0.30.0"
17110-
react-docgen: "npm:^8.0.0"
17111-
resolve: "npm:^1.22.8"
17112-
tsconfig-paths: "npm:^4.2.0"
17113-
peerDependencies:
17114-
react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17115-
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17116-
storybook: ^10.2.13
17117-
vite: ^5.0.0 || ^6.0.0 || ^7.0.0
17118-
checksum: 10c0/b231b6c393007a34171ed6159a0d0a9b0870ab9058f387f714a6579ba1dbc2b533064dd6d3ba2b2d4ae48ef2b252de14344da9d0f239aee486b2dcaf3f463c66
17119-
languageName: node
17120-
linkType: hard
17121-
1712217052
"@storybook/react-vite@npm:10.2.19":
1712317053
version: 10.2.19
1712417054
resolution: "@storybook/react-vite@npm:10.2.19"
@@ -17163,25 +17093,6 @@ __metadata:
1716317093
languageName: node
1716417094
linkType: hard
1716517095

17166-
"@storybook/react@npm:10.2.13":
17167-
version: 10.2.13
17168-
resolution: "@storybook/react@npm:10.2.13"
17169-
dependencies:
17170-
"@storybook/global": "npm:^5.0.0"
17171-
"@storybook/react-dom-shim": "npm:10.2.13"
17172-
react-docgen: "npm:^8.0.2"
17173-
peerDependencies:
17174-
react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17175-
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
17176-
storybook: ^10.2.13
17177-
typescript: ">= 4.9.x"
17178-
peerDependenciesMeta:
17179-
typescript:
17180-
optional: true
17181-
checksum: 10c0/1b2fe05730605cc785bceb8ca4f538ef69c149d54c7bd9dd6981366c38801c4f632ab2343f3e358b79bde5d0a088f38bba78d9efca169e6369a5b3fbf4153726
17182-
languageName: node
17183-
linkType: hard
17184-
1718517096
"@storybook/react@npm:10.2.19":
1718617097
version: 10.2.19
1718717098
resolution: "@storybook/react@npm:10.2.19"
@@ -42738,33 +42649,6 @@ __metadata:
4273842649
languageName: node
4273942650
linkType: hard
4274042651

42741-
"storybook@npm:10.2.13":
42742-
version: 10.2.13
42743-
resolution: "storybook@npm:10.2.13"
42744-
dependencies:
42745-
"@storybook/global": "npm:^5.0.0"
42746-
"@storybook/icons": "npm:^2.0.1"
42747-
"@testing-library/jest-dom": "npm:^6.6.3"
42748-
"@testing-library/user-event": "npm:^14.6.1"
42749-
"@vitest/expect": "npm:3.2.4"
42750-
"@vitest/spy": "npm:3.2.4"
42751-
esbuild: "npm:^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0 || ^0.25.0 || ^0.26.0 || ^0.27.0"
42752-
open: "npm:^10.2.0"
42753-
recast: "npm:^0.23.5"
42754-
semver: "npm:^7.7.3"
42755-
use-sync-external-store: "npm:^1.5.0"
42756-
ws: "npm:^8.18.0"
42757-
peerDependencies:
42758-
prettier: ^2 || ^3
42759-
peerDependenciesMeta:
42760-
prettier:
42761-
optional: true
42762-
bin:
42763-
storybook: ./dist/bin/dispatcher.js
42764-
checksum: 10c0/5ca338b707c3e7e94c16ecdcb00ca3c450157dceec758c15c416649e346e628a0e034d2265656650fc4fee4680631de7cc588e1a244e42cbb41af9416281a998
42765-
languageName: node
42766-
linkType: hard
42767-
4276842652
"storybook@npm:10.2.19":
4276942653
version: 10.2.19
4277042654
resolution: "storybook@npm:10.2.19"

0 commit comments

Comments
 (0)