Improve attachment upload media type detection

Author: ruibaby

package.json

@@ -58,12 +58,14 @@
     "chalk": "^5.6.2",
     "cli-table3": "^0.6.5",
     "dayjs": "^1.11.20",
+    "mime-types": "^3.0.2",
     "ora": "^9.3.0",
     "pretty-bytes": "^7.1.0",
     "semver": "^7.7.4",
     "string-width": "^8.2.0"
   },
   "devDependencies": {
+    "@types/mime-types": "^3.0.1",
     "@types/node": "^24.12.0",
     "@types/semver": "^7.7.1",
     "@typescript/native-preview": "7.0.0-dev.20260318.1",

pnpm-lock.yaml

@@ -148,6 +148,63 @@ test("tryRunAttachmentCommand dispatches upload subcommands from urls", async ()
   });
 });
 
+test("tryRunAttachmentCommand infers media type for local file uploads", async () => {
+  silenceStdout();
+
+  const uploadAttachmentForConsole = vi.fn().mockResolvedValue({
+    data: {
+      metadata: {
+        name: "attachment-1",
+      },
+      spec: {
+        displayName: "image.png",
+      },
+      status: {
+        permalink: "https://example.com/image.png",
+      },
+    },
+  });
+  const runtimeMock = {
+    getClientsForOptions: vi.fn().mockResolvedValue({
+      profile: {
+        baseUrl: "https://example.com",
+      },
+      clients: {
+        axios: {},
+      },
+    }),
+  };
+
+  const { AttachmentV1alpha1ConsoleApi } = await import("@halo-dev/api-client");
+  vi.spyOn(AttachmentV1alpha1ConsoleApi.prototype, "uploadAttachmentForConsole").mockImplementation(
+    uploadAttachmentForConsole,
+  );
+
+  const fsPromises = await import("node:fs/promises");
+  const tempFilePath = "/tmp/halo-cli-attachment-upload-image.png";
+  await fsPromises.writeFile(tempFilePath, Buffer.from("png"));
+
+  try {
+    await expect(
+      tryRunAttachmentCommand(
+        ["attachment", "upload", "--file", tempFilePath, "--json"],
+        runtimeMock as never,
+      ),
+    ).resolves.toBe(true);
+  } finally {
+    await fsPromises.unlink(tempFilePath).catch(() => undefined);
+  }
+
+  expect(runtimeMock.getClientsForOptions).toHaveBeenCalledOnce();
+  expect(uploadAttachmentForConsole).toHaveBeenCalledOnce();
+  expect(uploadAttachmentForConsole.mock.calls[0]?.[0]).toMatchObject({
+    file: expect.objectContaining({
+      name: "halo-cli-attachment-upload-image.png",
+      type: "image/png",
+    }),
+  });
+});
+
 test("tryRunAttachmentCommand dispatches delete subcommands", async () => {
   silenceStdout();
 

src/commands/attachment/__test__/attachment-entry.spec.ts

@@ -4,6 +4,7 @@ import { basename } from "node:path";
 
 import { AttachmentV1alpha1Api, AttachmentV1alpha1ConsoleApi } from "@halo-dev/api-client";
 import cac, { type CAC } from "cac";
+import { lookup as lookupMimeType } from "mime-types";
 import ora from "ora";
 import prettyBytes from "pretty-bytes";
 
@@ -67,8 +68,9 @@ export function resolveAttachmentUploadSource(options: AttachmentUploadOptions):
 async function loadFileAsAttachment(filePath: string): Promise<File> {
   const normalizedPath = filePath.trim();
   const buffer = await readFile(normalizedPath);
+  const mediaType = lookupMimeType(normalizedPath) || "application/octet-stream";
   return new File([buffer], basename(normalizedPath), {
-    type: "application/octet-stream",
+    type: mediaType,
   });
 }