Simplify logic.

Author: toddbirchard

aiohttp_aiofiles_tutorial/__init__.py

@@ -1,7 +1,4 @@
 """Make hundreds of requests concurrently and save responses to disk."""
-from asyncio import Task
-from typing import Tuple, List, Optional
-
 import asyncio
 import time
 from time import perf_counter as timer
@@ -21,24 +18,19 @@ async def init_script():
     """Initiate script by preparing an output file prior to executing tasks."""
     start_time = timer()
     async with aiofiles.open(FETCHED_URL_TITLES, mode="w+") as output_file:
-        await output_file.write("title,url\n")
-        done, pending = await create_and_execute_tasks(output_file)
-        if len(pending) == 0:
-            await output_file.close()
-
+        await output_file.write("title,url,\n")
+        await create_and_execute_tasks(output_file)
+        await output_file.close()
     LOGGER.success(f"Executed {__name__} in {time.perf_counter() - start_time:0.2f} seconds.")
 
 
-async def create_and_execute_tasks(output_file: AsyncTextIOWrapper) -> Tuple[List[Optional[Task]], List[Optional[Task]]]:
+async def create_and_execute_tasks(output_file: AsyncTextIOWrapper):
     """
     Open async HTTP session & execute created tasks.
 
     :param AsyncTextIOWrapper output_file: Filepath to local .json file to write output to.
-
-    :returns: Tuple[List[Optional[Task]], List[Optional[Task]]]
     """
     async with ClientSession(headers=HTML_HEADERS) as session:
         task_list = await create_tasks(session, urls, output_file)
         inspect_event_loop()
-        done, pending = await asyncio.wait(task_list)
-        return done, pending
+        await asyncio.gather(*task_list)

aiohttp_aiofiles_tutorial/writer.py

@@ -30,5 +30,4 @@ async def get_html_page_title(html_body: str, url: str) -> str:
     :param str url: URL associated with the extracted HTML.
     """
     soup = BeautifulSoup(html_body, "html.parser")
-    return f"{soup.title.string.replace(',', '')}, {url}"
-
+    return f"{soup.title.string.replace(',', '')}, {url},"