fix: address review — try/catch init, hoist readClaudeSessions, atomic write, CWD escape, execFile

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: grimmerk

docs/session-status-hooks-design.md

@@ -8,7 +8,7 @@ Show active session status (working / idle / needs-attention) via colored dots i
 
 | Status | Dot Color | Meaning | Trigger |
 |---|---|---|---|
-| **Working** | Purple `#CE93D8` | Claude is processing | `UserPromptSubmit` hook |
+| **Working** | Orange `#E8956A` (pulse animation) | Claude is processing | `UserPromptSubmit` hook |
 | **Idle** | Green `#66BB6A` | Waiting for user input | `Stop` hook |
 | **Needs attention** | Orange `#FFA726` | Permission prompt or question | `PermissionRequest` hook, or pending `AskUserQuestion` |
 | **Active (unknown)** | Purple `#CE93D8` | Running but no hook data yet | Detected via `sessions/*.json` but no status file |

src/main.ts

@@ -1793,17 +1793,21 @@ ipcMain.on('set-login-item-settings', (_event, openAtLogin: boolean) => {
 let statusWatcherCleanup: (() => void) | null = null;
 
 const initSessionStatusHooks = async () => {
-  const enabled = (await settings.get('session-status-hooks')) !== false; // default: true
-  if (enabled) {
-    installHooks();
-    // Start watching for status changes
-    if (!statusWatcherCleanup) {
-      statusWatcherCleanup = watchStatusDir((statuses) => {
-        const obj: Record<string, SessionStatus> = {};
-        statuses.forEach((v, k) => { obj[k] = v; });
-        switcherWindow?.webContents.send('session-statuses-updated', obj);
-      });
+  try {
+    const enabled = (await settings.get('session-status-hooks')) !== false; // default: true
+    if (enabled) {
+      installHooks();
+      // Start watching for status changes
+      if (!statusWatcherCleanup) {
+        statusWatcherCleanup = watchStatusDir((statuses) => {
+          const obj: Record<string, SessionStatus> = {};
+          statuses.forEach((v, k) => { obj[k] = v; });
+          switcherWindow?.webContents.send('session-statuses-updated', obj);
+        });
+      }
     }
+  } catch (e) {
+    if (isDebug) console.error('Failed to init session status hooks:', e);
   }
 };
 
@@ -1839,11 +1843,11 @@ ipcMain.handle('get-session-statuses', async () => {
   // Scan active sessions that don't have status files yet
   try {
     const activeMap = await detectActiveSessions();
+    const allSessions = readClaudeSessions(500); // hoisted out of loop
     const sessionsWithoutStatus = Array.from(activeMap.entries())
       .filter(([sessionId]) => !obj[sessionId])
       .map(([sessionId]) => {
-        const sessions = readClaudeSessions(500);
-        const session = sessions.find((s: any) => s.sessionId === sessionId);
+        const session = allSessions.find((s: any) => s.sessionId === sessionId);
         return session ? { sessionId, project: session.project } : null;
       })
       .filter(Boolean) as { sessionId: string; project: string }[];

src/session-status-hooks.ts

@@ -44,7 +44,12 @@ case "$EVENT" in
   *)                             STATUS="unknown" ;;
 esac
 
-echo "{\\"status\\":\\"$STATUS\\",\\"timestamp\\":$(date +%s),\\"cwd\\":\\"$CWD\\"}" > "$STATUS_DIR/$SESSION_ID.json"
+# Escape CWD for JSON (handle backslashes and double quotes)
+SAFE_CWD=$(echo "$CWD" | sed 's/\\\\/\\\\\\\\/g; s/"/\\\\"/g')
+# Atomic write via temp file + mv
+TMPFILE="$STATUS_DIR/.$SESSION_ID.tmp"
+echo "{\\"status\\":\\"$STATUS\\",\\"timestamp\\":$(date +%s),\\"cwd\\":\\"$SAFE_CWD\\"}" > "$TMPFILE"
+mv -f "$TMPFILE" "$STATUS_DIR/$SESSION_ID.json"
 `;
 
 /**
@@ -160,7 +165,7 @@ export const isHooksInstalled = (): boolean => {
   }
 };
 
-export type SessionStatus = 'working' | 'idle' | 'needs-attention' | 'active' | null;
+export type SessionStatus = 'working' | 'idle' | 'needs-attention' | 'unknown' | null;
 
 /**
  * Read all status files from codev-status directory
@@ -210,10 +215,10 @@ export const watchStatusDir = (
 export const scanInitialStatuses = async (
   activeSessions: { sessionId: string; project: string }[],
 ): Promise<Map<string, SessionStatus>> => {
-  const { exec } = require('child_process');
-  const execPromise = (cmd: string): Promise<string> =>
+  const { execFile } = require('child_process');
+  const tailFile = (filePath: string): Promise<string> =>
     new Promise((resolve) => {
-      exec(cmd, { encoding: 'utf-8', timeout: 3000 }, (err: any, stdout: string) => {
+      execFile('tail', ['-n', '50', filePath], { encoding: 'utf-8', timeout: 3000 }, (err: any, stdout: string) => {
         resolve(err ? '' : stdout);
       });
     });
@@ -234,7 +239,7 @@ export const scanInitialStatuses = async (
     if (!fs.existsSync(jsonlPath)) return;
 
     // Read last 50 lines
-    const tail = await execPromise(`tail -n 50 "${jsonlPath}"`);
+    const tail = await tailFile(jsonlPath);
     if (!tail.trim()) return;
 
     const lines = tail.trim().split('\n');