all: Fix warnings from clippy::wrong_self_convention

Author: lutter

graph/src/components/store/write.rs

@@ -207,7 +207,7 @@ impl EntityModification {
     }
 
     /// Turn an `Overwrite` into an `Insert`, return an error if this is a `Remove`
-    fn as_insert(self, entity_type: &EntityType) -> Result<Self, StoreError> {
+    fn into_insert(self, entity_type: &EntityType) -> Result<Self, StoreError> {
         use EntityModification::*;
 
         match self {
@@ -510,7 +510,7 @@ impl RowGroup {
                     Overwrite { block, .. },
                 ) => {
                     prev_row.clamp(*block)?;
-                    let row = row.as_insert(&self.entity_type)?;
+                    let row = row.into_insert(&self.entity_type)?;
                     self.push_row(row);
                 }
                 (Insert { end: None, .. } | Overwrite { end: None, .. }, Remove { block, .. }) => {

store/postgres/src/deployment.rs

@@ -110,15 +110,15 @@ impl OnSync {
         }
     }
 
-    pub fn to_str(&self) -> &str {
+    pub fn to_str(&self) -> &'static str {
         match self {
             OnSync::None => "none",
             OnSync::Activate => "activate",
             OnSync::Replace => "replace",
         }
     }
 
-    fn to_sql(&self) -> Option<&str> {
+    fn to_sql(self) -> Option<&'static str> {
         match self {
             OnSync::None => None,
             OnSync::Activate | OnSync::Replace => Some(self.to_str()),

store/postgres/src/detail.rs

@@ -546,7 +546,7 @@ struct StoredSubgraphManifest {
 }
 
 impl StoredSubgraphManifest {
-    fn as_manifest(self, schema: &InputSchema) -> SubgraphManifestEntity {
+    fn into_manifest_entity(self, schema: &InputSchema) -> SubgraphManifestEntity {
         let e: Vec<_> = self
             .entities_with_causality_region
             .into_iter()
@@ -568,7 +568,7 @@ impl StoredSubgraphManifest {
 struct StoredDeploymentEntity(crate::detail::DeploymentDetail, StoredSubgraphManifest);
 
 impl StoredDeploymentEntity {
-    fn as_subgraph_deployment(
+    fn into_subgraph_deployment_entity(
         self,
         schema: &InputSchema,
     ) -> Result<SubgraphDeploymentEntity, StoreError> {
@@ -611,7 +611,7 @@ impl StoredDeploymentEntity {
             .map_err(|b| internal_error!("invalid debug fork `{}`", b))?;
 
         Ok(SubgraphDeploymentEntity {
-            manifest: manifest.as_manifest(schema),
+            manifest: manifest.into_manifest_entity(schema),
             failed: detail.failed,
             health: detail.health.into(),
             synced_at: detail.synced_at,
@@ -653,7 +653,7 @@ pub async fn deployment_entity(
         .await
         .map(DeploymentDetail::from)?;
 
-    StoredDeploymentEntity(detail, manifest).as_subgraph_deployment(schema)
+    StoredDeploymentEntity(detail, manifest).into_subgraph_deployment_entity(schema)
 }
 
 #[derive(Queryable, Identifiable, Insertable)]